From: Andi Kleen <ak@novell.com>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: [PATCH] Remove unnecessary irq disabling
Date: Wed, 2 May 2007 11:58:17 +0200
User-Agent: KMail/1.9.6
Cc: Mark Lord <lkml@rtr.ca>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org
References: <20070501213050.GD6119@redhat.com> <4637D459.2040502@rtr.ca> <20070502044424.GA7049@redhat.com>
In-Reply-To: <20070502044424.GA7049@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200705021158.17759.ak@novell.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 19


> > What does that break, or was it already broken and this fixes it?
> I think neither. This function is only called at early bootup,
> (start_secondary() ), and most of its callees have interrupts off anyway.
> But maybe we do lose something. Andi, do you have a word on this?

We need to enable them somewhere, but cpu_idle will do it in the end.
So it should be safe to drop it. I guess keeping them disabled the whole
time will be a little safer against potential races.

I added the patch, but might want some cooking in -mm first because this
is always fragile code.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/