Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 5 Apr 2022 08:02:37 -0700
From:   Darren Hart <darren@os.amperecomputing.com>
To:     LKML <linux-kernel@vger.kernel.org>,
        Linux Arm <linux-arm-kernel@lists.infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Sudeep Holla <sudeep.holla@arm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Barry Song <song.bao.hua@hisilicon.com>,
        "D . Scott Phillips" <scott@os.amperecomputing.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Carl Worth <carl@os.amperecomputing.com>,
        stable@vger.kernel.org, Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v4] topology: make core_mask include at least
 cluster_siblings
Message-ID: <YkxaDT6jT73ZBgb3@fedora>
References: <3d58dc946a4fa1cc696d05baad1cf05ae686a86d.1649115057.git.darren@os.amperecomputing.com>
 <YkupgBs1ybDmofrY@fedora>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YkupgBs1ybDmofrY@fedora>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b0C0fDolLP8EcVKFg66boGghZKlT+LZFyq3FY5rXJT1Y8o/iAB2eaaGzU4pM?=
 =?us-ascii?Q?JeI/mKfOgM6N1AWKMIt38zUlawznWdY/GYVYnJ0gSJO/pvWCI++YhU68nCDj?=
 =?us-ascii?Q?yuV/w2bDXsfz4lMvW6QqWI9LpURknvwtcItPjx7eYAVya7GiZ3k8dFUjeTDj?=
 =?us-ascii?Q?3dEzEyVssdTagfaxya5ZUXvj9zuevZNJ9ANm4ejHQxqNZyBnzZYFcKTemy6e?=
 =?us-ascii?Q?LtkOt2EtJeETuTqxWQU+4GXno/jLZxBzeAHWEOxfQSEuURjuTARJZ8E143QV?=
 =?us-ascii?Q?x/JaTKqRraQ7OjusVggaSDrDz03SAjPlcVVVsiD8frvueybVeR1xMPFDqrL9?=
 =?us-ascii?Q?dNVS8qCT0Mkj2ixpIR8DxSiBWoOvGytWNF2B4lzT2eCwgqQ2xP4QstDHnr8V?=
 =?us-ascii?Q?3I4IWxgmE0tCiTS/cen0rqLQwv3S76zLYMdmVYy6bGuMC4cHxC1h1KtcUVA4?=
 =?us-ascii?Q?u6c8cgt7/fWTOErOaEdhNOKY5Nm9if1x5BVkzhKO72hz4ciCNtjjCFLO+p8S?=
 =?us-ascii?Q?/DCVJLB1ibsSWdKnNMCBbAZKxZMM+jJMChkAw9sIanObIoU9IAjS0PrTLcko?=
 =?us-ascii?Q?kLf9OEiKRllD4XvAeyzLstSRiaO2CuiQGQ66sR2CKQfJ3UN7TITBQ+Munmmf?=
 =?us-ascii?Q?a6r3plFUX/e9RhsJJlnBEi4lm5qWe8DZvC72RwcePmwrvHIpCelbhjUjSJPU?=
 =?us-ascii?Q?SY0FLy0bPsR9JMKKJCsXtyaiJ7ki0JpJOE/eFS93ZsHNK0r0C8IPHuNP3zlm?=
 =?us-ascii?Q?9NmH16lPghc+slfQ4HmPTezwUIGqxSVpcK4z42mufgl8I2WKJxdZ8lyiatEl?=
 =?us-ascii?Q?eevDf+Ah5mCRIZpvdMoOz5STcSSbJY4MrgQoBTt9coFHPqPhiLM4OqEfQ2BG?=
 =?us-ascii?Q?1mogwEEe5JeKavY9mm/OIqXIZYAIIRHTxa2IasqtgrK6PxZnV3j9Jrm8B8Oa?=
 =?us-ascii?Q?5z9X4X37Yw9w8KAZGJ0cM4GNacfVXE6BBqfKGTD05b+5ikb/8GtpE/FIJsog?=
 =?us-ascii?Q?0EkF5K0Qk3jrEJoxiuMUJltXZzoBOxXQHAlrX5QTilp9ju61VBNdALeNRARC?=
 =?us-ascii?Q?kvH6467W6sQjdn9jW6UN2EFewm0FJyMt6fs9nvgglhj7x3k/EzccYI06ZZ0s?=
 =?us-ascii?Q?56HUyA/wO2165fnW77EYWdKPW1ZVTwJ3o2r27GbLzXVevSru+8OfM201zPjv?=
 =?us-ascii?Q?Qno52n0WQXKkj8CW4EWqQapC4mwAeiJhvLFfzD3CBBwNeIp2TU1Rt4LOlo/e?=
 =?us-ascii?Q?v0Y90O000mJGxbB2IzAfm+p0hG6wHWat4X4zV5Rhxj14Mt/8aCq4GqY7kwow?=
 =?us-ascii?Q?3D6CQB9bG5D42ZxB1SwR0L1WZfm805F9YNzERNXbYnTC0WMe0enL1YDObDDh?=
 =?us-ascii?Q?VlFVLBtSGjwuEQr8MPwTg6DG/CmPgPYCl9n5Eu72ruZ5w1WK/Ac7Q4srx5iN?=
 =?us-ascii?Q?nsIw/pq8PoclJMqcrYt/YTdEMlKHnsYh36BOvpPZbFR6v7/aRP0C/IQYAzsu?=
 =?us-ascii?Q?lZR0gRjTcblz+zzo4ojpwNNDGrQ+tgiOrX7BGrFYZWwH0INDn0QiA0ZGuyU9?=
 =?us-ascii?Q?Bk2JNGsAJqw3jT9JwakHvhWwQ0zT95xGDbNuLE/ECOAHbOZ0FQBoynmgFcSE?=
 =?us-ascii?Q?n0F9SbWBm29rAWz3hv2HUc+6ikLtypv4iFctktXwpc7H2FssqP70AVEj5TrQ?=
 =?us-ascii?Q?TZN2XuRRVvuIGQv8OOPYfbC1Ka9hdudMHa8qGu6n/32eF+EWMOPIInt7brXM?=
 =?us-ascii?Q?9yMq59MWabTvhMf5v1u3Aqy8g+PHQli+jErmGhmSaQfF69cb2Qtj?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b9c9e2c-7557-4ea5-e550-08da171553a5
X-MS-Exchange-CrossTenant-AuthSource: SA0PR01MB6329.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 15:02:39.2885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2V+xOLG4KWDPO1GjS3o5O/FuZbnHrONxp7N9AN3CkhAuSvzD5G/s/qltQl/zRKFikbpnAydu865s0mhSPW6P5ixw3yIrHc/QLUr2CvBTp4FkzRYYXmfOZWcBdpZqLFiI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR01MB4978
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 04, 2022 at 07:29:20PM -0700, Darren Hart wrote:
...
> A bit more context on the state of review:
> 
> Several folks reviewed, but I didn't add their Reviewed-by since I added the
> IS_ENABLED(CONFIG_SCHED_CLUSTER) test since they reviewed it last. This change
> preserves the stated intent of the change when CONFIG_SCHED_CLUSTER is disabled.
> 
> Barry Song - Suggested this approach
> Vincent Guittot - informal review with reservations
> Sudeep Holla - Acked-by
> Dietmar Eggemann - informal review (added to Cc, apologies for the omission Dietmar)

Dietmar responded with his:

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

-- 
Darren Hart
Ampere Computing / OS and Kernel