Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
IronPort-SDR: nF4bIdbir6tW54lJVvUQyRZIS3rw6aVEmfkYoyQumGdLxvjXuyntHiVOdNUGB3oibnUMyam31o
 vE2KW82SA/tcY1F9Ic3sNVNExy5VD5fqVkDOAGLPoR3mC05rC9INWqJXvZQQU0snWQdxVeKvAN
 FxQhwA0AcJjCrhfN5OTHSZxNyNWm8Aq3Hn/3euOVWw4FyEhjkDQGwIc8UKC2elHazJms4UWlxA
 comP//c5KkNpkJjYAfj2JFIgp/42mDJMrcPoboljKg1iX19vNL2U+Rgye5sh9rGf8ix1NQR86N
 n8Ev3/IStfDPP9LOCs5HPS8y
IronPort-SDR: zogS5gFxZKZDzO+nS7PyogULYokmOHnthX3HAgZXpvseAocuZGokAB0VrGO6iSh4MwidrBg3I5
 6MZq7gFFjBCfHMUeLLjoac62A9JaoSSPBn3qAnEO9NZ4gSfi6M/HXegCt0YM6IbI0hKVHtf1os
 ZjK56zti9zt6RBAOpFq/g/jrDJr2W97XT2rvx4oQsR26Z0KDY5cHSNR7KxDUMA5FsVdoYo2eCj
 soKyixMgCNvg+Pr+pk49yPXnEXL39FT2Tk099JTuokEZDR0V//4CoTZE731/eP0EVgPbA7eRNO
 RiI=
WDCIronportException: Internal
Message-ID: <a984b4d6-bc7d-ef81-8bd6-34d50127174d@opensource.wdc.com>
Date:   Wed, 6 Apr 2022 17:10:45 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in
 ata_scsi_qc_new()
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, Christoph Hellwig <hch@lst.de>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-scsi@vger.kernel.org
References: <1649083990-207133-1-git-send-email-john.garry@huawei.com>
 <1649083990-207133-3-git-send-email-john.garry@huawei.com>
 <20220405055252.GA23698@lst.de>
 <f7bbb09f-562f-fce2-cd16-a1c67fc334b5@opensource.wdc.com>
 <febb03e4-ea1d-c7e1-58a6-fa564c902af0@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <febb03e4-ea1d-c7e1-58a6-fa564c902af0@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/22 16:16, John Garry wrote:
> On 06/04/2022 02:48, Damien Le Moal wrote:
>> On 4/5/22 14:52, Christoph Hellwig wrote:
>>> On Mon, Apr 04, 2022 at 10:53:10PM +0800, John Garry wrote:
>>>> From: Christoph Hellwig <hch@lst.de>
>>>>
>>>> It is a bit pointless to have ata_qc_new_init() in libata-core.c 
>>>> since it
>>>> pokes scsi internals, so inline it in ata_scsi_qc_new() (in 
>>>> libata-scsi.c).
>>>>
>>>> <Christoph, please provide signed-off-by>
>>>> [jpg, Take Christoph's change from list and form into a patch]
>>>> Signed-off-by: John Garry <john.garry@huawei.com>
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>>
>>> Although I still think merging the two patches into one to avoid all
>>> the churn would be much better.
>>
>> I agree. Let's merge these 2 patches.
> 
> I'd say that they are distinct changes.
> 
> Anyway, if that is the preference then who shall be the author? 
> Considering I did most effort I will be and add Christoph as 
> co-developed-by - please let me know if not ok.

Works for me.

> 
> thanks,
> John


-- 
Damien Le Moal
Western Digital Research