Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1062997pxb; Wed, 6 Apr 2022 07:53:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeYt0u6gpjMJJFuaGQiH0t0NGu1zNgwZa879sgvQWxzxpCN1tL1/oXdZnfNWP5t6/supaS X-Received: by 2002:a17:90a:a4c:b0:1ca:a723:aa76 with SMTP id o70-20020a17090a0a4c00b001caa723aa76mr10371953pjo.101.1649256811446; Wed, 06 Apr 2022 07:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649256811; cv=none; d=google.com; s=arc-20160816; b=RqdP5QFhFEJfli1QbA78yfGt9jEwlLbccfF52+FFpEHeeNqV8eRsIWnzkh+DV2EkE5 bIVDcsUIx4DKEYeXuKvS/rMdzpfW/a824K1QbFxmojfBxjm8FaRbH8o+0ABLQQ/UfAVS mjdb7IyWtfAJLpFUex3/MqOUTnU4uQjMazPeYYov6JgOZcFxP4+Y/S8EUGVemApUiv/v E00jYe/wUQOsYWBoC54hFCChS7IgaDQ5mXbp4zIgBEB7M6Oxy4D0gOW1KZ45ESviZ/4/ CRHTFCjmDRO2vYBE1enoDhyeYc3Vf7FyrjdJ3uqH49mPKvpMMAUsIa6swtPcMeHny2UL kPjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Kh6DytC11gdNi8W6tlBfwxpwxAPXKhPZpYoYh3mWIWo=; b=KjiMzRgwOH0SfeE/qpLF89VbPpy83al8QjxsTbObNQ70js0rDFLs02xrUbSq0w2Ece 06fFJM0niTaaSoZL3xg5moHhxfURv2sVtALnkADeoyDXKHpvEK3Ke4FUt62O5mLbJN0i E1yKwC0eAfUEvSORBhYEiGUSeL/r3bsIkOxyEbrEx4HucKCneHUTZhThCYmzJ6w5Wibb pGVGGczqVwXwFKoJ7TQxrAYREcrnXJ+bGV3chn34weXYgmkHAt7oLdaKGjlnCetu3BAv 4Az6fcpb4ok9xKxp7FYN9yCIJzJ9hAatndsTHWLzFvP0D9rmh4oQS/3oxVUQS69mMQJS MKXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rRSov9iU; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n17-20020aa79051000000b004fa3a8e0072si14795847pfo.297.2022.04.06.07.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 07:53:31 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=rRSov9iU; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 87B466A9129; Wed, 6 Apr 2022 05:45:11 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1452101AbiDFJhv (ORCPT + 99 others); Wed, 6 Apr 2022 05:37:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1457676AbiDFJe4 (ORCPT ); Wed, 6 Apr 2022 05:34:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0B4FE437; Tue, 5 Apr 2022 23:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kh6DytC11gdNi8W6tlBfwxpwxAPXKhPZpYoYh3mWIWo=; b=rRSov9iUqX+soc4Uk47rVun/mb 1kHfGTdgUwvptEg3vKe3iXKdrPPFWvn6KeXus0ze6+vOm8kx5mnC0UZcXWWE00Hm1lMPwLUgWLeVq hKB8eV0YXTs3/JpRIjS5KD33MBVJb6zndYj4uQlgdKaYNlJaRWGwXS+7uW4h4d9seTyTYeROJsTIB nO56czjBojnbv2To07xtTwvAgIlEhVVjU6MzrcMbUT3w0u0Km5R4IIjMLJHRvnoUjPKPzdtuLv1Ij OoXnzo4ekfrLvXUuPNHJOAeDUFvW6AO/0UpYQkBLSL2fKtqJBlyy/9qEpWMORDLL5v4PAGZ7wQ0Jk eAbzc2GQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbz0V-0042HW-3T; Wed, 06 Apr 2022 06:19:07 +0000 Date: Tue, 5 Apr 2022 23:19:07 -0700 From: Christoph Hellwig To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: sym53c500_cs: Stop using struct scsi_pointer Message-ID: References: <4948f86703d23e5048f4e24e649680259b2610f9.1649146056.git.fthain@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4948f86703d23e5048f4e24e649680259b2610f9.1649146056.git.fthain@linux-m68k.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +static struct sym53c500_cmd_priv *SYM53c500_priv(struct scsi_cmnd *cmd) > { > return scsi_cmd_priv(cmd); > } I don't even think we need this helper, all callers can just use scsi_cmd_priv directly. Otherwise looks good: Reviewed-by: Christoph Hellwig