Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <5093bff2-bc85-57b9-5f8b-ecb81417409e@redhat.com>
Date:   Tue, 5 Apr 2022 15:48:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RFC PATCH v5 032/104] KVM: x86/mmu: introduce config for PRIVATE
 KVM MMU
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <770235e7fed04229b81c334e2477374374cea901.1646422845.git.isaku.yamahata@intel.com>
 <55fa888b31bae80bf72cbdbdf6f27401ea4ccc5c.camel@intel.com>
 <20220401015130.GE2084469@ls.amr.corp.intel.com>
 <9e01bc014df60e215ba17432c06b6854f6dae3f8.camel@intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <9e01bc014df60e215ba17432c06b6854f6dae3f8.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/1/22 04:13, Kai Huang wrote:
>> I don't want to use CONFIG_INTEL_TDX_HOST in KVM MMU code.  I think the change
>> to KVM MMU should be a sort of independent from TDX.  But it seems failed based
>> on your feedback.
> 
> Why do you need to use any config?  As I said majority of your changes to MMU
> are not under any config.  But I'll leave this to maintainer/reviewers.

There are few uses, but the effect should be pretty large, because the 
config symbol replaces variable accesses with constants:

+static inline gfn_t kvm_gfn_stolen_mask(struct kvm *kvm)
+{
+#ifdef CONFIG_KVM_MMU_PRIVATE
+	return kvm->arch.gfn_shared_mask;
+#else
+	return 0;
+#endif
+}

Please keep it.

Paolo