Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1064277pxb; Wed, 6 Apr 2022 07:55:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyP0nA/DDvrfteb/HIFWP0kEEf9UN1xnoQQrfeNGpHKqNWNsb/CrMYBnCnUNpYH9uBPEOaD X-Received: by 2002:a17:90b:915:b0:1ca:b584:8241 with SMTP id bo21-20020a17090b091500b001cab5848241mr10377510pjb.46.1649256912067; Wed, 06 Apr 2022 07:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649256912; cv=none; d=google.com; s=arc-20160816; b=Yf+t1qZvgwV/CCarXhT442w19TArdsiUFwu50bWV7iudvY+H3dmCuyFv/IRar2WPl7 rkQzsdn6Sa35nNbE9C+Dd8sloGrF9+u6MAfrvF/lwcVoelzgKoIv1r08EQo6DuEzX15X wmAsjcTCxDiw9NJ+lygz/Ukx/zwnqD2Lt9CMhXsSqMQFdc0w8NqK+9vSnNDvkRzxqZJb HfLaiXSZAOfGxN6sj2h3SsbSFEuWPszJ91ISFMdZMV1iShdukxQDRf1M6aw4bwgPdOmA ErgGE2HvtfB7UzVO+kUx6wR8DGCimB27QYdZvMD8WQ06jEOm9tgb544n8rts/Qh3IKJF Ndmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=s5Rv2jt7aGLImfLJIiM/5w3K8YUbSOEx+pvCk6I5VMo=; b=bnSUy03RfD6Y0RWTbz02S5LiMnMuja16lpKRov9DHt+BBsDSewvvnGpr2c508huhOu j7jCPQ9XHvLPSvz2upHLHuUvR36Qa7axN0Kk/Mf5Pd+RZ8n5rCZeUAmu6MHvkucLMCXo 2+4aOkVwi81pAHNAz+9oL0QhhswrQui8KVKsaS6M4rvp+tsisCKW80GkOL/Fm/w6HoZe UTn98g3RSA3rqnLrEUL2qcGtsht6mpvSfi8LespN2RlMHuE26ppj28WZ7musEo6ES2Xp oDoTpYYhRrN5BjsdCFyCB0+jnG1YvnIavl4wB6fZLOcn+ZTnXjAa1VnSP2M+dw1Vrdja Vu4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rqdoUew9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p9-20020a170902b08900b00153b2d165d0si14758636plr.472.2022.04.06.07.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 07:55:12 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=rqdoUew9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 005E13709E5; Wed, 6 Apr 2022 05:39:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1850347AbiDFCwE (ORCPT + 99 others); Tue, 5 Apr 2022 22:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1587547AbiDFAJi (ORCPT ); Tue, 5 Apr 2022 20:09:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B549DE08E; Tue, 5 Apr 2022 15:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s5Rv2jt7aGLImfLJIiM/5w3K8YUbSOEx+pvCk6I5VMo=; b=rqdoUew930ZZ6zrAnlfvmOF/zf +YntEDiQq+lDqmtSifeD/BGDKf4g7GkHYLxudkmzdyK5cgH/wZucpnSc1cOEeqX5tzdZylyEm9uz5 KjdjRJUUJa9gUj9572C6PlpVQLKxTlLKuASQa0lhQMLBp52OQqySbhM/BMq/qghF0J67yro+frIqg XoDZgXOLgGwC3tfbvt999mOTUy6LqjcaDRWq7nkQZS2B3zJXHLy8ItBQFTzk4vxBpz7SFXJ3cmjCe SB/I/ptIkVnavZf3lWoOGDw3MGZDfUUipM9KeUyy8WAfhHKBIIH3x+GfmL+nyBA2iw4nUlGS8cNsW Tu+LgHDw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbrjU-0077Ix-P6; Tue, 05 Apr 2022 22:33:04 +0000 Date: Tue, 5 Apr 2022 23:33:04 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test Message-ID: References: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote: > - perror("open"); > - exit(1); > + switch (errno) { > + case EACCES: > + if (getuid()) > + printf("Please run this test as root\n"); Shouldn't all these be fprintf(stderr, ...); ?