Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1068645pxb; Wed, 6 Apr 2022 08:01:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAWHAJbQ80i1DjyKvFtFitZoGPRBsrZiNjAz2/COK2CCyoR0sgml1g0i3NQSJ3SPmA13tO X-Received: by 2002:a05:6808:1144:b0:2ec:b290:80e7 with SMTP id u4-20020a056808114400b002ecb29080e7mr3708321oiu.26.1649257278049; Wed, 06 Apr 2022 08:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649257278; cv=none; d=google.com; s=arc-20160816; b=cb3HYVXhes4voPwjWkLzE5niYCE5Iieccmm1X1mQXBkHHm7N9zgyp9/hBENg3Tnqk0 rXPbalzK3r++aJIElqx/WmAGvIGyquTYMN4QYgVCQvlwcRjygzzcqu/qJjkx6IxK7hGx Dcbt6EyMBN6rh3MXbTPepTXPGY5dYSK7OeFP6Gx+qgHF0YQmFRp0tjku6ruZYQ4dSnyY 2fbhRao9j16UXOc+X97d3PYIBN4VihQE9Gyh03iFbdrsOEQ7C/av7GJi+GW3WiMJVZRc X6nojW/fhrbNVDZk/TquLJqk+BaXrDgM/YuPL4yd/qtWJrjvDLIs5e0QrNauBfktL0gr vj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from; bh=9OiuwwhDaS637Pf4GIQML2l24Iuc8jtBFJ9jGPmdbDw=; b=za11mv3XMsIos+iUTY2ePEeBIRt5vH98W4A3EHieiAadD+y+dTTI/caG59WX8Si/T/ mb0QuPTSIzPaAWgeSCfkx1vyhCILSboByAvcJMhNB/PrSHERbCmVzYZi3jIfjucTrkHa umnQE2eDA6+r99OcUFAiqtCaXwFDZXIyx6M/I6QT0ozOjQl/iAMZGFYjBjhLxJTVdn4W H6pHCdDWTpBxmpqD0m4WK0xVWUu/LU36+iWJRLgeZW9d5xtuABZPNOmoAHkAt2FyDrI8 n1PFZ8XfICVtILUn82+4oKBSqCWx4GiE0fQ7VsuKUdxeqRH18F64193YOpaiZpN/83lO SRxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s6-20020a056830148600b005cb2fc1382asi9405652otq.166.2022.04.06.08.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 08:01:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DDE9532B309; Wed, 6 Apr 2022 05:48:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbiDFMjn (ORCPT + 99 others); Wed, 6 Apr 2022 08:39:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232144AbiDFMi3 (ORCPT ); Wed, 6 Apr 2022 08:38:29 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459D7576837 for ; Wed, 6 Apr 2022 01:40:23 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 4B3F11A13A5; Wed, 6 Apr 2022 10:40:15 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 00A8E1A129E; Wed, 6 Apr 2022 10:40:15 +0200 (CEST) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id CE566183AC4F; Wed, 6 Apr 2022 16:40:12 +0800 (+08) From: Sandor.yu@nxp.com To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com Cc: Sandor.yu@nxp.com, shengjiu.wang@nxp.com, cai.huoqing@linux.dev, maxime@cerno.tech, harry.wentland@amd.com, hverkuil-cisco@xs4all.nl, amuel@sholland.org Subject: [PATCH v1 3/5] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Date: Wed, 6 Apr 2022 16:48:35 +0800 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sandor Yu HDMI1.4b specification section 6.5.3: Source shall only send GCPs with non-zero CD to sinks that indicate support for Deep Color. DW HDMI GPC default enabled, clear gpc_auto bit for bpp 24. Signed-off-by: Sandor Yu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index b11577de4836..c7b11582529e 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1160,6 +1160,14 @@ static void hdmi_video_packetize(struct dw_hdmi *hdmi) HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK); hdmi_writeb(hdmi, val, HDMI_VP_PR_CD); + val = hdmi_readb(hdmi, HDMI_FC_DATAUTO3); + if (color_depth == 4) + /* disable Auto GCP when bpp 24 */ + val &= ~0x4; + else + val |= 0x4; + hdmi_writeb(hdmi, val, HDMI_FC_DATAUTO3); + hdmi_modb(hdmi, HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE, HDMI_VP_STUFF_PR_STUFFING_MASK, HDMI_VP_STUFF); -- 2.25.1