Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1078899pxb; Wed, 6 Apr 2022 08:13:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkEW12pWHf+64CLx2QPlmSIk+qbni83WeCRJVMpJVMLPNI1ABdJi/IhAnD+Gn58wQjckdB X-Received: by 2002:a05:6808:16ac:b0:2f9:52e5:da90 with SMTP id bb44-20020a05680816ac00b002f952e5da90mr3797133oib.5.1649257988814; Wed, 06 Apr 2022 08:13:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649257988; cv=none; d=google.com; s=arc-20160816; b=HcZhoRqiymlWzW6ABHd5r0+J29E8tetifKGNBRbAMHWISVr/wbX3HIejGKVr0pF03h Fz+huV7i37IXjpAhIR2Niils0lcVKxKZKfJ85xzbj+XvRb5KkAXnowCqQt71Hgj+6d1H bpGAdIwYgY2C59hSWLsC8aZBjchOiNJ8ziVr7BzIq8ufxshQEq8SSGBuHZ5bKhkCGXL1 xO09t5AHensBnWWDoqLclHUhVJS/uptO73sYUfM7ExN0ZVwUEA147JJHa5yup9mFLNrg q9kHewuP6mUSi89N1Z0J2IZ+miupGYGsPOO5o29Xi+LQ7maVq9BUHPD9G4Qg2Y2lZvBc 6xzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=3xqa3zQff+Io2JArriZqk5H3xdDEHifKgrjChaWfIJQ=; b=pz563OpPNOfmAMuRbW+Ff9MevEidC8L0COcOApsXOQmmu5BGsGDdmo3JqHrVJ7wPdk QDa6uj+k+TVkao4RDHLXIx+q6yuFy+3EEC/rBzhO9V6wm82ow+Nh3PCECkmNmGHPeGQh sPQrcxJvqe54ka6HYwR3hMW5YT4EV4+q94plYNqUhHz4fBP380jBvkzJSrZuvjqsXmjZ bMCLzdpZaua2DhtSNg+P7lmSLfedNI1HEjowEyiz9d6v6pRv6aJDUNP+gPzrE+CEU5kE LlQexVL4PQ0ymogCpHdSpVTj/VT4lOJdUMcuTlPSzywPBFuCUhxY/5T1x23xHmIIxizd aeGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=P8IT8nOS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y83-20020a4a4556000000b003244bc5df2asi8613947ooa.38.2022.04.06.08.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 08:13:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=P8IT8nOS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ED76E42BBA1; Wed, 6 Apr 2022 06:02:04 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230127AbiDFNDv (ORCPT + 99 others); Wed, 6 Apr 2022 09:03:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbiDFNCQ (ORCPT ); Wed, 6 Apr 2022 09:02:16 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A9B45BE763; Wed, 6 Apr 2022 02:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649237228; x=1680773228; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=3xqa3zQff+Io2JArriZqk5H3xdDEHifKgrjChaWfIJQ=; b=P8IT8nOS7zIuHLuFqvh879M/wkd6ok/JiTznAggAg5lcRWz7KDCKS3+D Hnp9wCoOJBTIWECzgwP5PFNKSkNvu7yM4y9KM/0zA/Pro5zkP34s3dRYK 4ghpvMbnXVYQaTkk7dNXQhOg7x/yu/NFZHHlryNwTYH8NbB4N1pp+ATGU o=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 06 Apr 2022 02:26:56 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 02:26:55 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 6 Apr 2022 02:26:54 -0700 Received: from [10.216.50.162] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 6 Apr 2022 02:26:50 -0700 Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC To: Stephen Boyd , Bjorn Andersson , Rob Herring CC: Lee Jones , Liam Girdwood , Mark Brown , , , , , , References: <1649166633-25872-1-git-send-email-quic_c_skakit@quicinc.com> <1649166633-25872-5-git-send-email-quic_c_skakit@quicinc.com> From: "Satya Priya Kakitapalli (Temp)" Message-ID: Date: Wed, 6 Apr 2022 14:56:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/2022 12:39 AM, Stephen Boyd wrote: > Quoting Satya Priya (2022-04-05 06:50:31) >> + >> +static struct platform_driver pm8008_regulator_driver = { >> + .driver = { >> + .name = "qcom,pm8008-regulators", > Also, the name should be something like pm8008_regulators I've seen the other qcom regulator driver names, I think I shouldn't be using coma here. How about qcom-pm8008-regulator ? similar to the other regulator drivers