Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <278b3ab9-a790-76f2-df6d-97b37d5e5e23@quicinc.com>
Date:   Wed, 6 Apr 2022 15:26:47 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add reset entries for
 SDCC controllers
Content-Language: en-US
To:     Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <devicetree@vger.kernel.org>,
        <krzk+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
        <robh+dt@kernel.org>, <ulf.hansson@linaro.org>
CC:     <quic_rampraka@quicinc.com>, <quic_pragalla@quicinc.com>,
        <quic_sartgarg@quicinc.com>, <quic_nitirawa@quicinc.com>,
        <quic_sayalil@quicinc.com>
References: <1647532165-6302-1-git-send-email-quic_c_sbhanu@quicinc.com>
 <1647532165-6302-3-git-send-email-quic_c_sbhanu@quicinc.com>
 <CAE-0n53BBzgU6AJ70JNUBBkDZ1c9ZmpX8ZXLcxLxmmg1=UnSLw@mail.gmail.com>
From:   "Sajida Bhanu (Temp)" <quic_c_sbhanu@quicinc.com>
In-Reply-To: <CAE-0n53BBzgU6AJ70JNUBBkDZ1c9ZmpX8ZXLcxLxmmg1=UnSLw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Thanks for the review.

Please find the inline comments.

Thanks,
Sajida

On 4/2/2022 3:39 AM, Stephen Boyd wrote:
> Quoting Shaik Sajida Bhanu (2022-03-17 08:49:25)
>> Add gcc hardware reset entries for eMMC and SD card.
>>
>> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index c07765d..cd50ea3 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -881,6 +881,10 @@
>>                          mmc-hs400-1_8v;
>>                          mmc-hs400-enhanced-strobe;
>>
>> +                       /* gcc hardware reset entry for eMMC */
> Please don't add this worthless comment.
>
>> +                       resets = <&gcc GCC_SDCC1_BCR>;
>> +                       reset-names = "core_reset";
> A "_reset" postfix is redundant. In fact, reset-names shouldn't even be
> required.
Ok
>> +
>>                          sdhc1_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>
>> @@ -2686,6 +2690,10 @@
>>
>>                          qcom,dll-config = <0x0007642c>;
>>
>> +                       /* gcc hardware reset entry for SD card */
> Please don't add this worthless comment.
Sure will remove the comment.
>> +                       resets = <&gcc GCC_SDCC2_BCR>;
>> +                       reset-names = "core_reset";
>> +
>>                          sdhc2_opp_table: opp-table {
>>                                  compatible = "operating-points-v2";
>>