Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755129AbXEBL4b (ORCPT ); Wed, 2 May 2007 07:56:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755116AbXEBL4a (ORCPT ); Wed, 2 May 2007 07:56:30 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:41983 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059AbXEBL43 (ORCPT ); Wed, 2 May 2007 07:56:29 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: David Howells Cc: "John Anthony Kazos Jr." , David Woodhouse , Geert Uytterhoeven , Satyam Sharma , Andrew Morton , Christoph Hellwig , Roland McGrath , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: condingstyle, was Re: utrace comments References: <20061127165138.GA2991@lst.de> <20070430040213.BF9901801A4@magilla.sf.frob.com> <20070430091121.GC31397@infradead.org> <20070430100917.439ebfc8.akpm@linux-foundation.org> <1178028973.2875.78.camel@pmac.infradead.org> <9185.1178035627@redhat.com> <24844.1178098371@redhat.com> Date: Wed, 02 May 2007 05:55:02 -0600 In-Reply-To: <24844.1178098371@redhat.com> (David Howells's message of "Wed, 02 May 2007 10:32:51 +0100") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 78 David Howells writes: > Eric W. Biederman wrote: > >> Not lining up with the code following the if statement is also >> a plus. Because it clearly delineates the conditions from the code. > > But the condition doesn't line up with the code: Exactly. The condition not lining up with the following code helps code helps separate the two. > if (veryverylengthycondition1 && > smallcond2 && > (conditionnumber3a || > condition3b)) { > this_is_some_code(); > this_is_some_more_code(); > } > > Personally, for complicated conditions like this, I prefer: > > if (veryverylengthycondition1 && > smallcond2 && > (conditionnumber3a || > condition3b) > ) { > this_is_some_code(); > this_is_some_more_code(); > } > > But that seems to offend Andrew for some reason (or was it Christoph? or > both?). Yes. Although I suspect simply not tucking the trailing brace is as good or better. I believe not putting the beginning brace at the beginning of the line is a violation of coding style. if (veryverylengthycondition1 && smallcond2 && (conditionnumber3a || condition3b)) { this_is_some_code(); this_is_some_more_code(); } However there is the practical way to solve this if you have a sufficiently large conditional, or the conditional appears several times. static inline int test_func() { if (!veryverylengthycondition1) return 0; if (!smallcond2) return 0; if (conditionnumber3A) return 1; if (condition3b) return 1; return 0; } if (test_func()) { this_is_some_code(); this_is_some_more_code(); } Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/