Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "S.J. Wang" <shengjiu.wang@nxp.com>
To:     "Daniel Baluta (OSS)" <daniel.baluta@oss.nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "daniel.baluta@gmail.com" <daniel.baluta@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>
Subject: RE: [PATCH] remoteproc: imx_dsp_rproc: Make rsc_table optional
Thread-Topic: [PATCH] remoteproc: imx_dsp_rproc: Make rsc_table optional
Thread-Index: AQHYROqwwU4P4PKJAku1tOtg7L4orqzitRgw
Date:   Wed, 6 Apr 2022 10:18:49 +0000
Message-ID: <DU2PR04MB90822E836A7415C43BBF7C0FE3E79@DU2PR04MB9082.eurprd04.prod.outlook.com>
References: <20220331103237.340796-1-daniel.baluta@oss.nxp.com>
In-Reply-To: <20220331103237.340796-1-daniel.baluta@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KGjI8Kh+Rb+ikQsLoAyNhspM8YZSF27KTXQYtwQa8xWlr28PBz+6Q2dWW41W?=
 =?us-ascii?Q?uvsJ2ow8Izy9tpmsOiEMSE9J8nB8ol9l6Bb1CYzwfSFcLYiYCaflHGXHtGkR?=
 =?us-ascii?Q?6jUY76PhzCJs81A8XBELxnwG8IdwJlBJEfBPNbCOPMqsFC0kwT+NYqtJcdoF?=
 =?us-ascii?Q?9pBR88AyusIuPGHbu5i/RkGAW8BT3qeByUXPQ5eHUJc/H1BJULbCxMRjNHa+?=
 =?us-ascii?Q?ppXszq0Uu9yoNx53oPWDoPLl7pLtyIdY0ePHQKFqniAhol7BPOEWf3GgeUD7?=
 =?us-ascii?Q?eIPkvdJFlLfX0BpRKHLZay0pUSVE67xZHO1q8mjB5LgGePE2W5KDCJoD5e6g?=
 =?us-ascii?Q?LZkKzxUJFjbzQwPGY6VViy0On+/uOmsbzy3L/PA8jdm45ZBuMv5hmy7OLfYY?=
 =?us-ascii?Q?jvjvTDJGwVJra6fk3XmgvyQewmzaOAC1b4HZnB6MknlsrLPLRZ+B3anKS3yG?=
 =?us-ascii?Q?wx6UNnlmFsrq/NN6RjPeXYt4+WaMaXauWyjQCSgM9rx+FBS3EfQuAVjT1onl?=
 =?us-ascii?Q?TgG1Fh930oE5a/e1+nOh7NAJPxMKLMAqXGgFfWgI5UNPxn+A913waVyyX9VW?=
 =?us-ascii?Q?OXmQwUeAJaSwIzmwODSebzkXXAiUCWiM9xfJLxQosh7qJH7fTvSCZmSvHfOg?=
 =?us-ascii?Q?+j8la+ceq5BtyjI/HlUd/63CNqpS3+vyMklLG9lHHf4Vwj7s9zOIQ0VKntcg?=
 =?us-ascii?Q?xkJrcGVih+aWHcCjmulTNTHU40pOmEYFEfxC4TNcyjavx6ESi3EVMRnivRlT?=
 =?us-ascii?Q?UvLOWrb+dI94Qg/gjqQBjRjpvXHuJBfxFWhtw4vUg8+Qc9EfKAwMTcfNhFuP?=
 =?us-ascii?Q?DcrZRlskeATCN7gggThzjlcNfmuyPidX0GuVxIeHd6fFETXNW2Dqqj8x7cTa?=
 =?us-ascii?Q?rh17EQDlIVKdd3dZ/4vZbkVPpalMwlidbGRhcl6Ev908gXaBOpLg0+U63rgX?=
 =?us-ascii?Q?KPVQ/wkSAlBEHp22N4SDpgGwflt4ijj5qFCU5ivJb9e5hSs+orqOhvF/41RY?=
 =?us-ascii?Q?s8TxA5nzxh4S0oX5Da4X8yyu2tvo0duFKBE+Dcvx6WmGskspuu7dg9xVTwme?=
 =?us-ascii?Q?TGNgAm23puJTqhGQ/2At88SWbLlLJe0k06WUoPxLftRTzVPPoDYhcX+yrRFa?=
 =?us-ascii?Q?sArVIqm+2eWYkZ6768GcuPSyw5uO3FzlDO17EMgMO08nyK2r7kszBhwQ+0Lv?=
 =?us-ascii?Q?6Eu2TjDPDiMcGmapA7Amj+I5oCl/SMwea3SYxPzcU1wZchB+qvtGe1GY5A0Z?=
 =?us-ascii?Q?0JiXKscYpQvw5a5YZ0Xi8IqdLYgpbBD24eScXwiVR5xO6wATkGG+7GvWdTOD?=
 =?us-ascii?Q?BI6b0eIMrrDYhEAftaZsum4Otl/Xdt6HZCTjN/OTtvgkFmFwXXwkuth4XmYZ?=
 =?us-ascii?Q?YBp943kqq08sNyrNuKPJDYZESNpTMH2QuXbSY3WaBxTQJOssUwnJ3BWgEqjT?=
 =?us-ascii?Q?eNf1FpO82kLckEOmVcLrjTxRB8DUUqkSpvQoiobtb4xgS1y5iR+mYX0LP4yt?=
 =?us-ascii?Q?sH0aU2hOX7jv1ZCzjHND4vH2vG18IuanvcSf3sB/kUgRmIhy2HVNVBEO9kfn?=
 =?us-ascii?Q?MGMbS0PN0UBRP1ZTa/z8paDZgsr9Tv90oG5Oqd9RGoDJ+LyhSxlvKMajvs6J?=
 =?us-ascii?Q?Q0Xsl9ib8TaptYf3AkqAtejDoY+umC10r9HqDsOr55Tk9KPpVRmqbobe2iyk?=
 =?us-ascii?Q?+cQUrarWU8+Y+JxV25pQT8SIyxj0Cr0XvOccyb3A0CIl4yMIECjBrF9Bxksy?=
 =?us-ascii?Q?yY2R52vKvQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9082.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33142ea9-0876-448b-a947-08da17b6d789
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 10:18:49.2706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qIXZ/D3lNGxKw3cDejsTwFzvg52w/DfcnHkuHgpBqH8EgT5RgXA8wXAKfLu9FLtGYRCYM82h/1zZOhiihmUoHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6330
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>=20
> There are cases when we want to test a simple "hello world"
> app on the DSP and we do not need a resource table.
>=20
> remoteproc core allows us having an optional rsc_table.
>=20
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
Wang Shengjiu

> ---
>  drivers/remoteproc/imx_dsp_rproc.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
> b/drivers/remoteproc/imx_dsp_rproc.c
> index 2abee78df96e..987ab1add761 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -802,6 +802,14 @@ static void imx_dsp_rproc_kick(struct rproc *rproc,
> int vqid)
>  		dev_err(dev, "%s: failed (%d, err:%d)\n", __func__, vqid,
> err);  }
>=20
> +static int imx_dsp_rproc_parse_fw(struct rproc *rproc, const struct
> +firmware *fw) {
> +	if (rproc_elf_load_rsc_table(rproc, fw))
> +		dev_warn(&rproc->dev, "no resource table found for this
> firmware\n");
> +
> +	return 0;
> +}
> +
>  static const struct rproc_ops imx_dsp_rproc_ops =3D {
>  	.prepare	=3D imx_dsp_rproc_prepare,
>  	.unprepare	=3D imx_dsp_rproc_unprepare,
> @@ -809,7 +817,7 @@ static const struct rproc_ops imx_dsp_rproc_ops =3D {
>  	.stop		=3D imx_dsp_rproc_stop,
>  	.kick		=3D imx_dsp_rproc_kick,
>  	.load		=3D imx_dsp_rproc_elf_load_segments,
> -	.parse_fw	=3D rproc_elf_load_rsc_table,
> +	.parse_fw	=3D imx_dsp_rproc_parse_fw,
>  	.sanity_check	=3D rproc_elf_sanity_check,
>  	.get_boot_addr	=3D rproc_elf_get_boot_addr,
>  };
> --
> 2.27.0