Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1096783pxb; Wed, 6 Apr 2022 08:38:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6HuoMe31WHLBTr3WwDBu/1zOC4Tp9dtImAcHVK5FpfmlN7L2g/sy5vyD9cZmclVlyXILv X-Received: by 2002:a63:af06:0:b0:378:3582:a49f with SMTP id w6-20020a63af06000000b003783582a49fmr7634068pge.125.1649259497744; Wed, 06 Apr 2022 08:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649259497; cv=none; d=google.com; s=arc-20160816; b=n/PPJl9IHqKlkBnweRHQ++TgQwDOdYsBgiJjGI2jRfRZ3EvehUGJ0QRnEzsQslDiIz 8h3xBM6TY4geFcQHpeKTntVrFNx6rZDOF11dhouQW6aALo8Qcwf+euXRVttmBmDgyFPy PYik6Pmzzy6HfzAJyFsyHLxtgHyBeptDOxeqsvp5cEkP0PzV+AJpwQ5zYnQPCm6zv2Fe 2h9nzdGRoa5bVypZf30b16p3PnzxsAbhPVIZqiRad1yp2yYS4F2feVg+eqSDQYbHnqd2 iVG9u3E2QjQsBQ0NEtSHH6kqAfhoF8e32BYmZ+9TcIJGMe+FKSHt0UyUNnRxAkOrp2wc jP5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GS3nLEVk0msHQNdiWuhGTquMWpFv5/80kOZvpT/8cg0=; b=ed7DelajisTv/KaUeEj+KvyXagqmMd+SlcVDG/H76pD1yZZgkUIc+wL+CxjupAUvOh 06fCx+JRCJ+zUh+lgs1dYQBw8/Yb6W5338e8nPabDin03FJYGHuEy3oX8Zcq3hJLzA85 Q+GqCgKJl6Z3/4pEKde5TF6XYF0fvj7LTHi84RgTLn9DR5gMndyouXSeNaGZfwp9/72w lIvM5g84BmFCUkDIdqnHRedRr+XHpTd5ScHT4sWzfAueNSEHP/glPiMNrBGlSOWdkRB5 4CV4o3WlwZNv4ot7blnfOsMyesALdfdfLY0pZ6gPiVBPf1p1Kwt7KbEOVQ6sQMCmeSB5 m2KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A67hvJf1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j66-20020a636e45000000b003816043f06dsi16622773pgc.610.2022.04.06.08.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 08:38:17 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A67hvJf1; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1188B31216A; Wed, 6 Apr 2022 06:52:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233894AbiDFNya (ORCPT + 99 others); Wed, 6 Apr 2022 09:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234203AbiDFNwi (ORCPT ); Wed, 6 Apr 2022 09:52:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF30C3D6FFE; Tue, 5 Apr 2022 18:26:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A93DB8203A; Wed, 6 Apr 2022 01:26:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 626D9C385A0; Wed, 6 Apr 2022 01:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649208403; bh=yJUkzJ/EKyf8PlyHyI5tKyWRwcgeyxQU+NZ1LoKG+vM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A67hvJf1WQOl0FRiyzVu3IF9JiybuDASSlOmGwGrHouCCOVLRcH6aayruhoje5i76 EfHq+sOQPLvaQdiYiOLhF4n4yfZmRJsqkxHmvAeQUYjxw4EgnUpMDyao89TYHne/Tz VYE6trXKmjyVls0jSKN05hJxqPMaGb5E15TD9dwQ8vQ3SszSD8LW+7C6176x4CtQrI VDB1xYSOh616c3ewbzi74UH/po4whOYsW9gDutA97LLAE8aFydFouD24xs0bzH/yoc 3LCRYZx/uzzivR8bfn0NgMXFey+iSKxEXIhTtySBjvia7sEf4srtlK+NwaGxrr8avs 4mZi0yfD9P3aQ== Date: Tue, 5 Apr 2022 18:26:41 -0700 From: Jakub Kicinski To: Xiaomeng Tong Cc: aelior@marvell.com, manishc@marvell.com, davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator Message-ID: <20220405182641.08cd18ff@kernel.org> In-Reply-To: <20220405002256.22772-1-xiam0nd.tong@gmail.com> References: <20220405002256.22772-1-xiam0nd.tong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote: > struct pci_dev *qed_validate_ndev(struct net_device *ndev) > { > - struct pci_dev *pdev = NULL; > + struct pci_dev *pdev; > struct net_device *upper; Please keep the longest-to-shortest ordering of variable declaration lines.