Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <802b944d-d168-d9c8-add3-1fe17f3985f5@linux.alibaba.com>
Date:   Wed, 6 Apr 2022 10:47:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [RFC PATCH] sched: avoid unnecessary atomic_read when
 sync_core_before_usermode() is empty
Content-Language: en-US
From:   Tianchen Ding <dtcccc@linux.alibaba.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Borislav Petkov <bp@suse.de>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        NeilBrown <neilb@suse.de>,
        Vasily Averin <vasily.averin@linux.dev>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org
References: <20220402030822.11441-1-dtcccc@linux.alibaba.com>
In-Reply-To: <20220402030822.11441-1-dtcccc@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

We've run schbench and found wakeup latency on some arm64 machines worse 
than others. Perf shows there's a hotspot on 
atomic_read(&mm->membarrier_state);

We're still working for the real reason behind it (maybe cache or sth 
hardware related), and we do see remove this function can help improve 
performance.

Thanks.

On 2022/4/2 11:08, Tianchen Ding wrote:
> On archs except x86, CONFIG_ARCH_HAS_SYNC_CORE_BEFORE_USERMODE is not
> defined. We found membarrier_mm_sync_core_before_usermode() looks like
> this when compiled by gcc10:
> 
> 	if (current->mm != mm)
> 		return;
> 	atomic_read(&mm->membarrier_state);
> 
> This memory access is unnecessary. Remove it to improve performance.
> 
> Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
> ---
>   include/linux/sched/mm.h | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
> index a80356e9dc69..3ded68d9f913 100644
> --- a/include/linux/sched/mm.h
> +++ b/include/linux/sched/mm.h
> @@ -401,6 +401,7 @@ enum {
>   #include <asm/membarrier.h>
>   #endif
>   
> +#ifdef CONFIG_ARCH_HAS_SYNC_CORE_BEFORE_USERMODE
>   static inline void membarrier_mm_sync_core_before_usermode(struct mm_struct *mm)
>   {
>   	if (current->mm != mm)
> @@ -410,6 +411,11 @@ static inline void membarrier_mm_sync_core_before_usermode(struct mm_struct *mm)
>   		return;
>   	sync_core_before_usermode();
>   }
> +#else
> +static inline void membarrier_mm_sync_core_before_usermode(struct mm_struct *mm)
> +{
> +}
> +#endif
>   
>   extern void membarrier_exec_mmap(struct mm_struct *mm);
>