Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [v3,2/2] rtl8xxxu: fill up txrate info for gen1 chips
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220325035735.4745-3-chris.chiu@canonical.com>
References: <20220325035735.4745-3-chris.chiu@canonical.com>
To:     Chris Chiu <chris.chiu@canonical.com>
Cc:     Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org,
        code@reto-schneider.ch, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chris Chiu <chris.chiu@canonical.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164924448932.19026.12333806311207815732.kvalo@kernel.org>
Date:   Wed,  6 Apr 2022 11:28:14 +0000 (UTC)
Precedence: bulk

Chris Chiu <chris.chiu@canonical.com> wrote:

> RTL8188CUS/RTL8192CU(gen1) don't support rate adaptive report hence
> no real txrate info can be retrieved. The vendor driver reports the
> highest rate in HT capabilities from the IEs to avoid empty txrate.
> This commit initiates the txrate information with the highest supported
> rate negotiated with AP. The gen2 chip keeps update the txrate from
> the rate adaptive reports, and gen1 chips at least have non-NULL txrate
> after associated.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>

You ignored Reto's comment in v2 about misspelling of adaptive, but I'll fix
that during commit.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220325035735.4745-3-chris.chiu@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches