Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1128810pxb; Wed, 6 Apr 2022 09:22:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztH3BbFYw15zV3IHXMILlX2ZuqSepL3QHS2vZH9H38zF1ZrhqxzDspnWeBV2wPnyw/VH0p X-Received: by 2002:a17:902:c951:b0:154:4f52:34b2 with SMTP id i17-20020a170902c95100b001544f5234b2mr9326077pla.41.1649262131024; Wed, 06 Apr 2022 09:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649262131; cv=none; d=google.com; s=arc-20160816; b=pZBoRQse7eKaAaFRcBE1PAGm3O0DTxOwzvwxEp81XmlzNoh+LrWPotK/LZE27jMHE+ RzQd1ANONLnDaujKvsxXG9rZEC6Oym41cy1+mJIzsQf4pTM6sQNruat1AO/hIU+teZ6m ok1zOSv3qE1ngWcGpduPpqrX9LFI+N0YJsHlvKKNSiWTBmK/i360aEv+SyFInKZ+UDBM ukRT8dqRrX5zwHYlTMOmIck4yZLbWY/e9R7K1nP/EZJ+mWRZzNp/5QeIKtBID9yr910P MfEkXYYk4rvKCzJQ4QBOfqbK3S75tYiRcnKSBMLLkEv0koD0tYMC6PimeVu1KaeyA/xY Keuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=X/VqDp9KKtPE6iqhL4P1CRi1/QDv8iUO0My6yIPQh2Q=; b=Wtr4ir0q9yvGpYLyhPOeBeF2oL9bpI+j20f3DJzaiy+qdfXukk39lbRN8sFTiyljSY zEpms5uEg/QnlKs0xbE9uKSo489tH61dbWu4K0TVTgP2mb/S46du05GGOrLGZ99hIzxo TwBGrg4xcUw2DkeXoee1iXUUrX61YYmj+Ze1FLQ6eFDN/861E574xEJMNBPNK1LwIJuH FneY2ahQcZv9owkVJu8yipFnH7Qyz/FAu3nW++Q3SMApMY32Z3hCSmRtmzsJO1t1XAnY 4HoLCWv2BlTBrwN0AYefdf++tPkKRVCK8lbUbmIZBRZA43DRX8F8jkJajV10SoArkDO5 ws6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=g0BD1LF3; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id t2-20020a170902e84200b00153bc4c8989si17655441plg.204.2022.04.06.09.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 09:22:11 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=g0BD1LF3; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 27EDF20BC8; Wed, 6 Apr 2022 08:21:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235860AbiDFPXm (ORCPT + 99 others); Wed, 6 Apr 2022 11:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236471AbiDFPXE (ORCPT ); Wed, 6 Apr 2022 11:23:04 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5B545F38F0; Wed, 6 Apr 2022 05:23:12 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 89D031F4452C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649246250; bh=KeK63JgstL220HZeT8Eh0tNYtvHxor/1CeEp/mCXIg4=; h=From:To:Cc:Subject:Date:From; b=g0BD1LF33XBXk5bDckOc92DJvC+EWtN1wj7NORKaXCUpqG+9cOPZJVgOq5Ni+3ahf yjytUdiXEX9nXSsF3TjVgJ0WnzitjiZNCezEc9aH2Y11lfMJnHdYu3s06VCFmnBPJV wxEt11fauvCuNSXhoeHvrn7G7IJ5gR6N6nyDMvZ9HECatNjEG3lJbhggZZgG3+JAE1 hqvpI12iQoRdBuCagB70QJZYL37OvkwqFAbVFrEpIcn2FFTCkJQpVDPu11Uf1QEl8M xZu/3hEzTQ8L8cjszOX4LFERAwFSwm6YeaJYSJ29lx4SJwiWTgbVM9uEcan1HPEzjC M8Y4tHajnI0RQ== From: AngeloGioacchino Del Regno To: dmitry.torokhov@gmail.com Cc: matthias.bgg@gmail.com, mkorpershoek@baylibre.com, lv.ruyi@zte.com.cn, m.felsch@pengutronix.de, angelogioacchino.delregno@collabora.com, fengping.yu@mediatek.com, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: mt6779-keypad: Move iomem pointer to probe function Date: Wed, 6 Apr 2022 13:56:54 +0200 Message-Id: <20220406115654.115093-1-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mmio base address is used for the only purpose of initializing regmap for this driver, hence it's not necessary to have it in the main driver structure, as it is used only in the probe() callback. Move it local to function mt6779_keypad_pdrv_probe(). This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/input/keyboard/mt6779-keypad.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c index 0dbbddc7f298..2e7c9187c10f 100644 --- a/drivers/input/keyboard/mt6779-keypad.c +++ b/drivers/input/keyboard/mt6779-keypad.c @@ -24,7 +24,6 @@ struct mt6779_keypad { struct regmap *regmap; struct input_dev *input_dev; struct clk *clk; - void __iomem *base; u32 n_rows; u32 n_cols; DECLARE_BITMAP(keymap_state, MTK_KPD_NUM_BITS); @@ -91,6 +90,7 @@ static void mt6779_keypad_clk_disable(void *data) static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) { struct mt6779_keypad *keypad; + void __iomem *base; int irq; u32 debounce; bool wakeup; @@ -100,11 +100,11 @@ static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) if (!keypad) return -ENOMEM; - keypad->base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(keypad->base)) - return PTR_ERR(keypad->base); + base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); - keypad->regmap = devm_regmap_init_mmio(&pdev->dev, keypad->base, + keypad->regmap = devm_regmap_init_mmio(&pdev->dev, base, &mt6779_keypad_regmap_cfg); if (IS_ERR(keypad->regmap)) { dev_err(&pdev->dev, -- 2.35.1