Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1137878pxb; Wed, 6 Apr 2022 09:34:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/ObcBLbt0RLXm1B3Qx7enU92F8NkoLgcLB+1ETOblb3uUooK3PZn5NmX7Tl0ao39plKaW X-Received: by 2002:a63:cf09:0:b0:372:d564:8024 with SMTP id j9-20020a63cf09000000b00372d5648024mr7791793pgg.251.1649262896817; Wed, 06 Apr 2022 09:34:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649262896; cv=none; d=google.com; s=arc-20160816; b=Ckmr6v5TZm8lLkRGjz1svick6fXDXoFX/N9QIK8GTJKCcQJkHRd/+j9m5GbMCb9PhB 1F4iM/bkh8wizEmNwgw05F99KDs4nh6JjZ7UhPyYKpFDIclux+ZCXxagxNKRlmPxC2// YUFDgZkLA6Pl4X742s+/l+wzRFwKfbO9Q4AFMznJRGH82EnIDVeHtP0hOWewWDz4zd4k U628EG0jf1lRdr01fL/i1YLAeaCHLULLMFuv+vnYJUuZPxWBu2WFg7gO0NmjnhmBDctY NALkQ+pOihYkFvWuK8Ko1JqOa9zfXZXy7I6XCgd934AHt7NZOKHGKrea1+ZyaWqpJt2S xxCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=xfiPvAQOxy6dh5KfXGS8/tUHCjpX4q1zL23rveGfwYE=; b=hvka9JUQe/d32n4CnpUv3SVMouw2Mnf6pxMgExXT+w8YWxLlOjVv7yScPrOlu//B1b tlzPI1raGXabHBJ71ksw3TtX45E9wGpXi7T1g4J+W2hrXCTn8tMpTtZrfEXZ6ClidaNe 4KzyvCYoD+l9Fu+tNIC76UZrg9CaQ1WLmalLo3a25njmoTgxVtmBY9FKAwv2VA0WzFCN /swG8RPmP7RICP/a1NS5MCHeMOWiyM37O8zW4dM2JXxZ9TdkZYD6mxDePFxYttAa90OL tQaFPzF0r8Hj9WE3rLQ7q+O4Dm1EPaaL1dGnS70+4mEnMJyUtYuQVSNGC1TJMJFQ50fe tInw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LuhfRRhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e12-20020a170903240c00b00153b2d165f5si14825354plo.509.2022.04.06.09.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 09:34:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LuhfRRhR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D33F02F7EA2; Wed, 6 Apr 2022 08:43:22 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236179AbiDFPpF (ORCPT + 99 others); Wed, 6 Apr 2022 11:45:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236427AbiDFPoK (ORCPT ); Wed, 6 Apr 2022 11:44:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B4124DFA8B; Wed, 6 Apr 2022 06:10:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C62260B90; Wed, 6 Apr 2022 13:10:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id A4ADBC385A9; Wed, 6 Apr 2022 13:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649250613; bh=gj3LnrzDBuaBA3oZSCTUUn9xPtQQhfhC2uOBuoJ25XA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=LuhfRRhRfrFWQ0/fNsOfFJuB3enFBIVG+V18wgMH1txyXomZs3ixmBEy2dPw8S3vW i99J0sC/t9h1HBWsZ/RazKLguyNUK9XOgSi6nFGfqQdr7BJgYcyig+2VixvCjoeiY8 Y0K6pG1NlB72DSlmVKstA4lTv5ZPjixgnpNCo3O2XDeCebFTE0JdxHrlF+9e55yhKH nnykBZZPrxO7ANzBsltPvD1N1RQPrfjvU+MC+gUykp3GVBlLSQkjAVCM16NofsWfkS N/hb7tBPIcZKPu7DXPK/1EBzakb576kfl4/hoOpJfDwh1T1TdKDVoNsh1OrVvnaJsr VTCtcSp18Ux1w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 89A90E85DB6; Wed, 6 Apr 2022 13:10:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] net: openvswitch: fix leak of nested actions From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164925061356.5679.9687443822548515643.git-patchwork-notify@kernel.org> Date: Wed, 06 Apr 2022 13:10:13 +0000 References: <20220404154345.2980792-1-i.maximets@ovn.org> In-Reply-To: <20220404154345.2980792-1-i.maximets@ovn.org> To: Ilya Maximets Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, dev@openvswitch.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, pshelar@ovn.org, tgraf@suug.ch, stgraber@ubuntu.com X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Mon, 4 Apr 2022 17:43:45 +0200 you wrote: > While parsing user-provided actions, openvswitch module may dynamically > allocate memory and store pointers in the internal copy of the actions. > So this memory has to be freed while destroying the actions. > > Currently there are only two such actions: ct() and set(). However, > there are many actions that can hold nested lists of actions and > ovs_nla_free_flow_actions() just jumps over them leaking the memory. > > [...] Here is the summary with links: - [net] net: openvswitch: fix leak of nested actions https://git.kernel.org/netdev/net/c/1f30fb9166d4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html