Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 6 Apr 2022 15:04:39 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.15 327/913] lib: uninline simple_strntoull() as well
Message-ID: <Yk2P58P53btqLAgr@kroah.com>
References: <20220405070339.801210740@linuxfoundation.org>
 <20220405070349.652301661@linuxfoundation.org>
 <Yk2I7JXzXaXi+6R1@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yk2I7JXzXaXi+6R1@localhost.localdomain>
Precedence: bulk

On Wed, Apr 06, 2022 at 03:34:52PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 05, 2022 at 09:23:09AM +0200, Greg Kroah-Hartman wrote:
> > From: Alexey Dobriyan <adobriyan@gmail.com>
> > 
> > [ Upstream commit 839b395eb9c13ae56ea5fc3ca9802734a72293f0 ]
> > 
> > Codegen become bloated again after simple_strntoull() introduction
> > 
> > 	add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-224 (-224)
> 
> > -static unsigned long long simple_strntoull(const char *startp, size_t max_chars,
> > -					   char **endp, unsigned int base)
> > +static noinline unsigned long long simple_strntoull(const char *startp, size_t max_chars, char **endp, unsigned int base)
> 
> This patch doesn't fix any bugs, why it is selected?

Easy change to make the kernel a tiny bit smaller?