Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1140683pxb; Wed, 6 Apr 2022 09:38:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi3tuUVdipTQE/bJ9dhxp41mgQiOud5//DJlIAiGFNlwlnWfAvXo7cn/fr8DKGcF/yESaI X-Received: by 2002:a63:9d8f:0:b0:398:dad:c3d8 with SMTP id i137-20020a639d8f000000b003980dadc3d8mr7924181pgd.228.1649263138035; Wed, 06 Apr 2022 09:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649263138; cv=none; d=google.com; s=arc-20160816; b=ENl7Qm2F0EEYtPZStgFzBBfIhkcoxMU7uep8EiTe9SUmLyOLB8HU6DXVX2x90sHFb5 agTGSjGeb8vnKF5mamEJaTeoKW66JnrpvhtVNiFFTUSP5byLGt8/KvfLlSm2jKf/itFf iDnxbsgbQB/dsBs3KmQvqw3RPRDWShLx27iHFXXTC+FDn4JDsCl2lUUKwD4l3vmvVHA6 F5OnnH7wVHlo0N7TGj4oztOUMDfYbeVi62gXrW1mSofnEZcMN8PXEMxI63tb8FJVvwp0 Almt0n/ygCZ4+zbGgxqHj+P3SjkDNA/v48LXEni11N8XQB55pJ/vbx00O5Co9Caws+YO iOxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date:dkim-signature:dkim-signature; bh=ny6SkW/jjvFpcVUGJahdGz/N3Zi6Zn73i10e9D2Lh3E=; b=D9e9hXWxHKx7kZgus8SuhvsHJ73RI8SJrBsQU/HAJVMGlxh69ohGtnrP/NWiJmIAUm AoFiohux/0SfNs2lNpNqHGi5zY1ElRQ4QVcMsuQjp9LGFjB8TwmcbuqODRTlcBFf6rHZ 9ZSHoffr2/5s1aYI9LQLf+7yxhKvkq7VtZ0pDuoneSvGYQaW9eNSvbxWLGM89c4Dxpwy qtwmyIJ8ZsPJSdKrwZue7NwLcWHAC1WqkkH09yumngKBVWMFrSp1+qBQEeB7peFYbYbZ QBZFAsC7844ycRHPFgXnhdVvHfzwOquNGia1ubTguJOWnfgflUozcRz6lXMwwNkg2Cka DqGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=UZlmD6C1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 186-20020a6309c3000000b003990deab146si11273535pgj.595.2022.04.06.09.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 09:38:58 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=UZlmD6C1; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5075239973D; Wed, 6 Apr 2022 08:47:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236704AbiDFPtZ (ORCPT + 99 others); Wed, 6 Apr 2022 11:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236424AbiDFPs1 (ORCPT ); Wed, 6 Apr 2022 11:48:27 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 719434961DE; Wed, 6 Apr 2022 06:09:31 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1B58C210F4; Wed, 6 Apr 2022 13:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649250535; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ny6SkW/jjvFpcVUGJahdGz/N3Zi6Zn73i10e9D2Lh3E=; b=UZlmD6C1rcVd7c9TYRt/MA0lDF47JspYw//BPhBSRvqyAnMd4a3lIiZ4eizQW9DFdw/MHF 1dWIeP+32cmwnnlMnyAgHZDmH0NzATbB6x2tf2x2b3ag10oCI9XF2FAx26O0dmeSq2S0Oo nCF+YTvEuyLdMC6V7+atUIVQr7+R+HQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649250535; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ny6SkW/jjvFpcVUGJahdGz/N3Zi6Zn73i10e9D2Lh3E=; b=85Vj1nlNdiZXDGccmK9QqluymfR/owT8jdecNZDrZ/7Xncs1RHkrzEnpmk5uyyEvqjRY7E BtKfJojqA68BCgCA== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id C6AD5A3B83; Wed, 6 Apr 2022 13:08:54 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 32AB9DA80E; Wed, 6 Apr 2022 15:04:53 +0200 (CEST) Date: Wed, 6 Apr 2022 15:04:53 +0200 From: David Sterba To: cgel.zte@gmail.com Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH] Btrfs: remove redundant judgment Message-ID: <20220406130453.GB15609@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, cgel.zte@gmail.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot References: <20220406090404.2488787-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406090404.2488787-1-lv.ruyi@zte.com.cn> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2022 at 09:04:04AM +0000, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > iput() has already handled null and non-null parameter. so there is no > need to use if(). Ok, we can drop the check, have you looked if there are more similar places to update?