Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 6 Apr 2022 10:10:05 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        slade@sladewatkins.com, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 000/599] 5.10.110-rc1 review
Message-ID: <20220406101005.25d1f915@gandalf.local.home>
In-Reply-To: <Yk1Op5c0mbtR0VLw@kroah.com>
References: <20220405070258.802373272@linuxfoundation.org>
        <20220406010749.GA1133386@roeck-us.net>
        <20220406023025.GA1926389@roeck-us.net>
        <20220405225212.061852f9@gandalf.local.home>
        <20220405230812.2feca4ed@gandalf.local.home>
        <20220405232413.6b38e966@gandalf.local.home>
        <Yk1LMYzEOv7vmEHR@kroah.com>
        <Yk1N5Vg+YrGxrfVo@kroah.com>
        <Yk1Op5c0mbtR0VLw@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 6 Apr 2022 10:26:15 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> Wait, no, I did catch this!  And I sent you a "FAILED" email about it, 4
> of them:
> 	https://lore.kernel.org/r/164905985821176@kroah.com
> 	https://lore.kernel.org/r/16490598521299@kroah.com
> 	https://lore.kernel.org/r/1649059845215213@kroah.com
> 	https://lore.kernel.org/r/16490598398133@kroah.com
> as the commit applied, but broke the build:

Yes, I know, that's how I knew it was an issue ;-)

> 
> But I didn't drop the offending commit, I should have done that.

Correct.

Oh, so I guess it got in because it applied, but broke the build. Thus,
your scripts catch when a Fixes does not apply, but doesn't handle the
"broken build / boot" case?

> 
> I'll go and drop the offending commit here, if you could submit both of
> them as working backports to stable@vger if/when you want them queued up
> there, that would be great.

The patch that got backported only fixes an issue with new events (hence
why I did not mark it for stable). If those events are not backported,
there's no reason to backport this one.

-- Steve