Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f742b6b8-4056-543c-17a5-ae373ca71b45@amd.com>
Date:   Wed, 6 Apr 2022 16:43:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/amdgpu: Senseless code and unnecessary memset
Content-Language: en-US
To:     Jani Nikula <jani.nikula@intel.com>,
        Grigory Vasilyev <h0tc0d3@gmail.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Melissa Wen <mwen@igalia.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Jiawei Gu <Jiawei.Gu@amd.com>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220405173632.2663-1-h0tc0d3@gmail.com>
 <614a4844-fa5d-8b8e-0628-894394f31608@amd.com> <874k3670ez.fsf@intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <874k3670ez.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXVaM2FKdmdib2IrTSt4a2VBcSt0ZDJjOHZiTDJuYWowazBnaXVwTmhPcmVU?=
 =?utf-8?B?NHhsSVJneVczcFhUdkFqaDF2RWlyLzYwMHhCSmk1cmNUQTY3NTM5ZXNSdUpI?=
 =?utf-8?B?MU1TTTNxQTIvTzRHZnpIQVk0NTMya05VOHJiQm8wR29FRG9jRDRIVVJlMWNs?=
 =?utf-8?B?eWFJYWZZalUvRzJWVnJVaGZjSnNRZDVPcm1UNXErRytQRmo0RmNPNlpDV1ZX?=
 =?utf-8?B?SmNXS25ZVVZzaDlvajR2ZDhxSlEwQ1hLUUpuV3RVZVJLa1pUUVUxU2xFaEI1?=
 =?utf-8?B?TXE3Y29iWlFkWEswQWJnUloxUHdiV010dXFUOEtiL0F1ZGtZbnQ4Q2dwTUdS?=
 =?utf-8?B?VksycmQxdDhFOHllZDA0WlZjMElwVndYeEVMMXNPU3ZEdUxJNHorVXNiQnJX?=
 =?utf-8?B?dmw0dFgzdDJoeG0xS2hJTFNMSUM5bE9qR1ZVdXA3NkhhUWR0OGtCdThQVklq?=
 =?utf-8?B?RXBDMjJhK1lPYzdxQm9kMk9PTy9sT1crN3FsWXRrU3luSzF4ek42L3B1K2pr?=
 =?utf-8?B?QVBEbkdaaGo2ZTBQSjU1VVkwdmowNUROK1FvUkNpZ2ZhcXJsRHJnTzFHMW5V?=
 =?utf-8?B?UEZ4Q0liMFhWWmVVdU9WbklqVzBUcTNiNWx6K2V6MEFEdEZ4MEFaQkU1WkEr?=
 =?utf-8?B?OVB0OTVqVmRqVXFzVFFjK0pXQWlob1dWVHY2NmhxSUE3d3c4S2I2VU5wMk0z?=
 =?utf-8?B?K2lxeTdQUWI0dldmdW1KS0U0cmtad2VqMDFKRWJUcmNFY3FoZWNRWHp1eUFx?=
 =?utf-8?B?b1UwRUxqWUFja3Uvb09vWTNsalA2OEJTZW5DNG9VSFB4WjdSc2RQTXBEdUpz?=
 =?utf-8?B?d3hlZVlSenV5WUVmZkg2Sjhkc3QwWnlDYXNpYkRsbUIzeUM0cGZwUkwzRlBo?=
 =?utf-8?B?cWlTY2J3d1NCRCtMWFQxOUt4eHo3cFVNblVmZ1pUSkpqNWFBMzlpUm04MU9h?=
 =?utf-8?B?NitjN0FHUmFJeURvazdPRHpyVVoxZ04rWWFKQ2Z1OTRlYk4va2pSMzJVVkpY?=
 =?utf-8?B?OTVDWmVKaG1ab0FmaFNsU3dYeTZ0blNMVE5SeWZhWXg0anB2NVh6VTNMeGNs?=
 =?utf-8?B?RTdzcmtDU29xR0w3aDJMOXFPNHVTUXVXLzdjZ2kvMW9RWlp2S09yS2lnY0Qy?=
 =?utf-8?B?c0tKMVZTZ3F5UXFicGw4ZloxbEdnMGZmck9mTnc1TlF2U29rSjdaMXordGZ2?=
 =?utf-8?B?dXM5dW5melZSVmhaeHJCTzBpek5HaWZMV2d1d3RaMXZoMmpnYSsva3BlNElT?=
 =?utf-8?B?WXAyNlpzTEp5WFVIUjB6Q2FNVDJCaHRCaGxvRjlvN0lyNGFnSHZWZTQvTkhK?=
 =?utf-8?B?VVYrakI5UVE1a2UyaEZVU3NJQUVjaW9nUmx5VjFTejB0TnZrTXVoVWZ5aW4w?=
 =?utf-8?B?OUUrSE5ZdTYvQmtRQnI4dzZvSllpS1prRUVsaDZzVkcrR1B4UkxLYXExVW9R?=
 =?utf-8?B?bTlWTkNFd3h6TTRHckNIbGdvSjM4Qzl6aC9MZ2x1ZTlFRnNtNE9yMUxIZktQ?=
 =?utf-8?B?bjFaU0FIRmxZQ2YrNmxyT0VCSTZHKzlZVzlaUGhacWdoY2tyY21tSHIvb292?=
 =?utf-8?B?MGp1MDlmcmNvUjRmeTNLSkIwSDhhK0RHWHBGYWp4UUk1UDZaOGREQm5Wenlr?=
 =?utf-8?B?eUFUMEtCWE1oM0ZMWWpqcEpTakZZRTFudWtodVl6TExOYzR3YzFxeitXUTg0?=
 =?utf-8?B?bkdQNnR5OFZzRG90dko2OUpadUNRWjBkSnI0bFg4Z1Jsc1VxNmp4dmRMWDQv?=
 =?utf-8?B?RlB3QjFRN1pKK3pmS2RTNGs0Zk0xOXErZU12eFdGYkpjdVJ3Q20wbmozQTdT?=
 =?utf-8?B?ZnI3Z1VrMXJlSjY2dGt4REF5UkFKNW9KN0pLUDhoYlFlaDVRODhBS21kY0Ry?=
 =?utf-8?B?dkVlSWU5NHZjODBaMjRqcThCcVUxbUhLT2hsU21yQi8vcWlIU1B3T0tZQ0Vt?=
 =?utf-8?B?NGJlSTNGOVVVaXlldW9zMmI4Tk40MUNQVlNhR3Rxd1ROTk5mODYzWTNMcHdT?=
 =?utf-8?B?a3pUTWpKQ1pBZkVHcUZDUGVPbFhiTytkNkNwc2dEWHYzQ2o4Y1FYTkhVTUpQ?=
 =?utf-8?B?c2tHbVBLQUJOWFcrNDYrVVJYejJ0MVpRT0F5VkwzZzNqSXNQNXZGZkc1RzMz?=
 =?utf-8?B?bjBNQk1QQ2RBbW1icDBvekY0aGJqaUtDanprODZhdC9QVXlhTXBEMkttWWdT?=
 =?utf-8?B?VkxFdHh4TmhiOWFCeW5sc2ZOVlNMUnRIa20wNGtrQzN1QldmVXN5VHRnYkg2?=
 =?utf-8?B?MURrNnhjUVM1R0JLWlB3QVYxWnhIZURMU1I3UzRLSEdWbEQyeG5FWU1VWktI?=
 =?utf-8?B?NjFxM0hCemtacDl6L3lDRGQ0dGZvTlZvT1YxdVhMVUJsaGE5WTJmUkFqSU1v?=
 =?utf-8?Q?mxhMGpsu7cDruUCQ4H9jec/5f9Ez5RktyXuxsrZPXeEMf?=
X-MS-Exchange-AntiSpam-MessageData-1: ICfeOWufZuN4Mw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b64d9cd4-eb2a-41fc-294c-08da17dbcd81
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 14:43:24.7854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wdIZNZoeGt9ZRnm4kZAgfdKBJh7/7oKuQqwQ2pkIxpl7bIp3untvG6Tq4s9daiup
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2899
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 06.04.22 um 16:26 schrieb Jani Nikula:
> On Tue, 05 Apr 2022, Christian König <christian.koenig@amd.com> wrote:
>> Am 05.04.22 um 19:36 schrieb Grigory Vasilyev:
>>> Using memset on local arrays before exiting the function is pointless.
>>> Compilator will remove this code. Also for local arrays is preferable to
>>> use {0} instead of memset. Mistakes are often made when working with
>>> memset.
>> Well actually memset is preferred when working with structures which are
>> given to the hardware parser because {0} won't initialize paddings.
> Not that I'd know anything that's going on here... but it sure seems
> strange to me to be passing unpacked structures where the padding might
> matter to a "hardware parser".

Well to me it is an absolute miracle why the heck compilers don't 
initialize paddings.

We had so many ups moments over the years and I really don't see why it 
should be more optimal to do this.

Anyway, the memset() is used intentionally here and I don't really want 
to change it. What we could do is removing the second superfluous memset 
and use sizeof() instead of hard coding the size.

Regards,
Christian.

>
> *shrug*
>
>
> BR,
> Jani.
>
>
>> So please don't use {0} in any of the atom bios code.
>>
>> Regards,
>> Christian.
>>
>>> Signed-off-by: Grigory Vasilyev <h0tc0d3@gmail.com>
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/atom.c | 8 +-------
>>>    1 file changed, 1 insertion(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c
>>> index be9d61bcb8ae..537e48fbbe6b 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/atom.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/atom.c
>>> @@ -1538,11 +1538,9 @@ struct atom_context *amdgpu_atom_parse(struct card_info *card, void *bios)
>>>    int amdgpu_atom_asic_init(struct atom_context *ctx)
>>>    {
>>>    	int hwi = CU16(ctx->data_table + ATOM_DATA_FWI_PTR);
>>> -	uint32_t ps[16];
>>> +	uint32_t ps[16] = {0};
>>>    	int ret;
>>>    
>>> -	memset(ps, 0, 64);
>>> -
>>>    	ps[0] = cpu_to_le32(CU32(hwi + ATOM_FWI_DEFSCLK_PTR));
>>>    	ps[1] = cpu_to_le32(CU32(hwi + ATOM_FWI_DEFMCLK_PTR));
>>>    	if (!ps[0] || !ps[1])
>>> @@ -1551,10 +1549,6 @@ int amdgpu_atom_asic_init(struct atom_context *ctx)
>>>    	if (!CU16(ctx->cmd_table + 4 + 2 * ATOM_CMD_INIT))
>>>    		return 1;
>>>    	ret = amdgpu_atom_execute_table(ctx, ATOM_CMD_INIT, ps);
>>> -	if (ret)
>>> -		return ret;
>>> -
>>> -	memset(ps, 0, 64);
>>>    
>>>    	return ret;
>>>    }