Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <963000ce7e7c8f94697be460441747f25f9247cb.camel@perches.com>
Subject: Re: [PATCH] staging: rtl8712: remove Unnecessary parentheses
From:   Joe Perches <joe@perches.com>
To:     Julia Lawall <julia.lawall@inria.fr>,
        Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc:     outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
        florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Date:   Wed, 06 Apr 2022 11:08:54 -0700
In-Reply-To: <alpine.DEB.2.22.394.2204061735340.2349@hadrien>
References: <20220406152858.14076-1-eng.alaamohamedsoliman.am@gmail.com>
         <alpine.DEB.2.22.394.2204061735340.2349@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2022-04-06 at 17:37 +0200, Julia Lawall wrote:
> If you want to capitalize something in the subject, it could be the first
> word.  Capitalizing the second word is a bit strange.
> 
> On Wed, 6 Apr 2022, Alaa Mohamed wrote:
> 
> > Reported by checkpatch:
> > 
> > CHECK: Unnecessary parentheses
> 
> Indicating that the problem was detected by checkpatch is good.  But
> actually, the parentheses all have the same property.  So you could use
> the log message to describe what kind of unnecessary parentheses were
> removed.  That would help the maintainer know what to look for.
[]

> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
[]
> > @@ -82,9 +82,9 @@ static inline void handle_pairwise_key(struct sta_info *psta,
> >  	       (param->u.crypt. key_len > 16 ? 16 : param->u.crypt.key_len));
> >  	if (strcmp(param->u.crypt.alg, "TKIP") == 0) { /* set mic key */
> >  		memcpy(psta->tkiptxmickey. skey,

Also, the space after the periods here are not great either.

		memcpy(psta->tkiptxmickey. skey,
vs
		memcpy(psta->tkiptxmickey.skey,