Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8010f544-852a-d7cd-3c3b-4e9cbcef3ab9@intel.com>
Date:   Wed, 6 Apr 2022 10:51:44 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH V3 14/30] x86/sgx: Support restricting of enclave page
 permissions
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <dave.hansen@linux.intel.com>,
        <tglx@linutronix.de>, <bp@alien8.de>, <luto@kernel.org>,
        <mingo@redhat.com>, <linux-sgx@vger.kernel.org>, <x86@kernel.org>
CC:     <seanjc@google.com>, <kai.huang@intel.com>,
        <cathy.zhang@intel.com>, <cedric.xing@intel.com>,
        <haitao.huang@intel.com>, <mark.shanahan@intel.com>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>,
        <nathaniel@profian.com>
References: <cover.1648847675.git.reinette.chatre@intel.com>
 <8ed9ee98ca26c9eefde0fd49062bca6e7b9efe80.1648847675.git.reinette.chatre@intel.com>
 <c9071aa19076c7c618294f0c9cb830a8be96ae09.camel@kernel.org>
 <26ab773de8842d03b40caf8645ca86884b195901.camel@kernel.org>
 <91a02d50b2cba34dfb058fd864ba20ef1e6a5554.camel@kernel.org>
 <10303ca73ea02a300636580e87446766374f66cb.camel@kernel.org>
 <6e0feeadc562b9e3f0a524040469d4f5c3484824.camel@kernel.org>
 <ca08465b6fa8af4121592c6381023fda5e0ade70.camel@kernel.org>
 <59910ad4-a898-4eb2-5e2b-856c686b53fb@intel.com>
 <0f44fba956288bcad69e076f84118bc50f8e5d2f.camel@kernel.org>
 <38603303-f683-cb79-57e5-57fad5c5ae3b@intel.com>
 <2bf954521a3cfc7c677887b1eef772cfcc9e3157.camel@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <2bf954521a3cfc7c677887b1eef772cfcc9e3157.camel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTVkMjdzaUduaU5taGJUYmdjQ0hCanF2dm04QVNSOG5aNC8yOHBFeHQvQ0NZ?=
 =?utf-8?B?MnV0UTdrU280a3BmbmI3Z0xpTlF2ZjI1ekUwUnE4YUFqdGNnRDk1Rlh6UG5X?=
 =?utf-8?B?bVlqV0tKSXBPYjB0MTNJd0FFanNsc0s5V2FPT0FJczNadzlPbjFJMlVSbTZ6?=
 =?utf-8?B?T0ZrVXJXeWFJMVRVeHFOMEJCZk00a1NzalI3Q1MxSGkyL0tNdTBYRmE0dHZR?=
 =?utf-8?B?dk04L1N5NTZvOVVpSVJXZE9ubUVzajdKSklBU2E5RWE4cHBiUFJlWEhwZ05E?=
 =?utf-8?B?TmRDdDlTbGowR3JwTzBteFE0cElKcWlCc1BDU2k3QUR6emVJUHJNbEdCdXZZ?=
 =?utf-8?B?bkQ1WFJNSGdTeTZuSEhTb2l1RW9IRkRLWVhFZzNZZG1xdzJXS1lVbzhDR1dI?=
 =?utf-8?B?RzN1QnN2eEVOMyt3UFNkZDNMZmpEcGV0M0p5cktEc0o2UUc5QUs3UEtUTDVR?=
 =?utf-8?B?Y3p5K3hGV0QyUzFyUGFJMUdjV1lDYlhyeEh0VmF1ams1YXVmdnVRalk1cXlP?=
 =?utf-8?B?ZXR1VitJR2U3WEU5bDVrR1RpN2tReW5iWnZ6RHZCdmpPeXNyRERXN25Ia21w?=
 =?utf-8?B?VXBDUWZvSDBnTHAwRzduU2JJbnRhVjBhaXJqbmxhcUJHSG4rOVhhUHE2MWZy?=
 =?utf-8?B?L3ZKQWI0aFVSVWp5cS9MNS8wUlV6RXBtZFBKNDZPVEN3UUkyaFRkTk9ZMVJZ?=
 =?utf-8?B?bVFZQVU3d0ZsSzJOZEtCQ3Z1d2t0WnRISE9vTjNYZzkwMHRSV1RNcS84TE1V?=
 =?utf-8?B?dnNBLzlkSlovY1ZwNjN4UnUvcEFOQ1dWRFhPT1lGZTRuVkhhRzUxMVFpYnVy?=
 =?utf-8?B?cjRwbVZsMGtuNEQxTXF6MjhaWktEM0tsWTZGdld5ZXJqQ3FTRFEzN1ZQQ1ps?=
 =?utf-8?B?QTNuNjZpZGVkRTl6Zlk4eUErRloyek1UN3ZMbWRrODRwT3UxWnMrN3B0TjRM?=
 =?utf-8?B?RGIzei9xZndqUEdDMHBGcnE2YmN6bUt0cU10UWpqS0VBMjBKL2pyUTZFd3lJ?=
 =?utf-8?B?STZuQ3dNU292d3RuRFF2dXBxcXUvV3d0dEhGWFI5MEhGUEpCSzhiZFZiSWQ2?=
 =?utf-8?B?OS9ENUowUEloby9RQkkvS0YwbFh2cVUzc0Rubm14YkJFUWM3cy8wSXNMdVpR?=
 =?utf-8?B?dEEzUzVjVFl1NXYwUjdZSWVOWVZiVkRPb1J3VEIzTXV3MEdTSmVuYnpLTjFi?=
 =?utf-8?B?K09aMGVCamp5N1RPZVNiK3pwNmhYVkNpS3NNem1ISldsZkRWNHVTaUdUOVVH?=
 =?utf-8?B?QzI1bDZ6QWlBeVh3em9HdXUwVUFoaEhLa0JML0lYN09VUHZtVm80bGhZL2dD?=
 =?utf-8?B?d0RDYUZ1RzNNRXJ1RVczU3E2VVllblJzR0hZUW41Z3RuRzR4VytJMGZvbS9u?=
 =?utf-8?B?UDlIdnZtREMxdG9pbWcxQ2FKWWJlMS9UMXVtbEJBK0c5aWlEM29selFjQVBQ?=
 =?utf-8?B?ZENxQjBLaFJvUmNlZkVPZGYrNXJLTUlWN1NLN3BWS1ZTcEZRbit0SkpNSUFP?=
 =?utf-8?B?RG01VXZNMjFVWmw0RlFYN1JZdzQ1WDg4dUtQZkVrbkM1dkRabzhTN1h5VTVS?=
 =?utf-8?B?QW9HQ1lWSXhRRHBwbnFFL1JvRVNJYnlHOU5VUktkTXNQbCtkZ2Q4a0NETnpa?=
 =?utf-8?B?L0o4NGZyd21XWW81dDNOSmhtWkRQSUExNG94eDM1K0I1TjI4eVlabTNVRjdh?=
 =?utf-8?B?eWM5aFVqdTNhamo1OEg4bXRnOWp3bXVnRDhXUkFNTFBMaGI0ZHdURjBzbTFu?=
 =?utf-8?B?dStjSEZiSGZrSUVramNNQUtnb1ZLQjh4TEJ1Z1R3SnFQSllzdU15alZGS2s1?=
 =?utf-8?B?YUEvR2J4RjE2cVFVRzM1a0RLVmNDclJnSDZWUlVGVzhkR1FRNVdJRjh0eHl6?=
 =?utf-8?B?RXlZRkZKWE9LOXRGNFZpRFRlN3g5MU50UWdVUHhEZW1LVk13RkFwdHRJdDdC?=
 =?utf-8?B?S0w3d3BRS3FBNTE4SGUrSzZzMGkzaFJTQkcxUDZwYnBpWWpKZWQ1NjdsaUpk?=
 =?utf-8?B?V3M4RXpRQ3E5Q3dBbjN6UFJtNG1mT0dpVEFUM2NhWHJUU1VIcmk5L3VYUE5u?=
 =?utf-8?B?d294a1RZZCtaRnpFb3djU1ZJakEvSDRUcHZKL003ZGU2K3V0WkxtSWs0UlVw?=
 =?utf-8?B?SjNBSGNlOWt5TStOUnNzenQxQ1dQQnZRWjJCSVpDaXg5N1NtbG9Fa2tHaitP?=
 =?utf-8?B?enZvT3JFMDJWVitqbEZxQVpoNVRkVHVHSkpRSmk5WEc4SDNUeXRlSGZvLzNl?=
 =?utf-8?B?WUZxTjRBRW02YW5yeVFCVzZqOFIxVnZKbDl3ejA3ZlIxR1BsajRGc0JDREd4?=
 =?utf-8?B?cmlSbHRERmpDNlBPSTBPeWdPWjJwMStWVVBmYXF6QnVzNkdtaEVGR3p0NTJN?=
 =?utf-8?Q?Lmjdf7cv44WqAgaA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b526051-9674-4f19-f8a6-08da17f61f44
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 17:51:48.3947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s/h4cRodUvEELmnmh56bhHhEeq4ZqgGcaYRXImsXBaMRhZKDEJh0yfjhhE16aRDXw3EQg+QKz9JzgAgHvXpFJKInCbD/hrmPywdGeQI7VM4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3303
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 4/6/2022 12:30 AM, Jarkko Sakkinen wrote:
> On Tue, 2022-04-05 at 11:59 -0700, Reinette Chatre wrote:


>> I plan to replace the current "secinfo" field in struct sgx_enclave_restrict_permissions
>> with a new "permissions" field that contain only the permissions. Please let
>> me know if you have concerns with this (I also discuss this more in reply to
>> your other message related to the page type change ioctl()).
> 
> I'm cool with it but if it is named as "permissions", then 
> it is already software-defined entity, i.e. meaning just that
> have this check in place in the ioctl:
> 
> if (addp->permissions & !(PROT_READ | PROT_WRITE | PROT_EXEC))
> 	return -EINVAL;
> 

I assume that we do still want to ensure that
PROT_READ is always set.

I was planning to keep it in the "SGX language" since
this is about changing EPCM permissions with values from
a runtime understanding SGX permissions in secinfo that will
be provided to hardware understanding SGX permissions in
secinfo.

Thus:

if (params.permissions & ~SGX_SECINFO_PERMISSION_MASK)
	return -EINVAL;

if (!(params.permissions & SGX_SECINFO_R))
	return -EINVAL;


Reinette