Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Apr 2022 18:27:44 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Satya Priya <quic_c_skakit@quicinc.com>,
        Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com,
        quic_subbaram@quicinc.com, quic_jprakash@quicinc.com
Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008
 PMIC
Message-ID: <Yk3NkNK3e+fgj4eG@sirena.org.uk>
References: <1649166633-25872-1-git-send-email-quic_c_skakit@quicinc.com>
 <1649166633-25872-5-git-send-email-quic_c_skakit@quicinc.com>
 <CAE-0n53G-atsuwqcgNvi3nvWyiO3P=pSj5zDUMYj0ELVYJE54Q@mail.gmail.com>
 <Yk1B4f51WMGIV9WB@sirena.org.uk>
 <CAE-0n53Cv_bR92M64dhdnDge_=_jeOs4VZzDhUkksN90Y7rgog@mail.gmail.com>
 <Yk21pdu16lyR8jXm@sirena.org.uk>
 <CAE-0n50C8khP2x4sgNP5xnfLVMRQj2=LChyWWx1BWL+Xgecgyw@mail.gmail.com>
 <Yk3Bfnxe/meBYokp@sirena.org.uk>
 <CAE-0n53O23=N0zkZpg87Q3EyKquLe3WLNJT8qnZz4WEor6QK7A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="004SQJl7509giZyq"
Content-Disposition: inline
In-Reply-To: <CAE-0n53O23=N0zkZpg87Q3EyKquLe3WLNJT8qnZz4WEor6QK7A@mail.gmail.com>
Precedence: bulk


--004SQJl7509giZyq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 06, 2022 at 10:21:01AM -0700, Stephen Boyd wrote:
> Quoting Mark Brown (2022-04-06 09:36:14)
> > On Wed, Apr 06, 2022 at 08:51:48AM -0700, Stephen Boyd wrote:

> > > My guess is that this is one IC that responds to multiple i2c address=
es.
> > > The "main" qcom,pm8008 address is 0x8 and that supports things like
> > > interrupts. Then there's an address for regulators at 0x9 which contr=
ols
> > > the handful of LDOs on the PMIC.

> > So it's like the TI TWL4030 and Palmas - in which case it should
> > probably be handled similarly?

> How did those work out? I wasn't involved and I don't know what you
> mean. Do they have multiple i2c addresses they respond to?

Yes, exactly.  The main device uses i2c_new_dummy_device() to
instantiate the extras when it probes.  See twl-core.c

>=20
> > Note that the original sumbission was
> > *also* a MFD subfunction, but using a DT compatible to match the
> > platform device - this is the first I've heard of this being a separate
> > I2C function.

> I'm mainly looking at the dts file now. It clearly has two i2c devices
> at 0x8 and 0x9. Maybe the regulator driver followed the mfd design
> because the first driver for this device is an mfd.

I'm guessing from the naming that they're also externally described as
the same device - presumably it's two dies shoved together in the same
package for some reason without being otherwise joined up.  Is the
second device geniunely regulators only or does it have anything else
bundled in there?

--004SQJl7509giZyq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJNzY8ACgkQJNaLcl1U
h9BXDQf9HHPmN8O2BxmVgWl0924qhTw/rou4mgZ3GdP/YtQLxAe7A2e6GzabQjKE
M/82tK6k4zp0QJtXTHsqRgdpAYintpwbabCQKzku1DHfNTFSivLhouIiFPqO+qlT
3X6zsi8OwWHjJs7CZxJ4SeFNQ1Nwn63W+BMqeGl6K775QQ2JgRc1Qit42PZl/6SA
nLAnL5p7F4a0WfKdw/HOWjhmjhwdI1OauB8lYVBgOWrZburTbeR9sWmnrLRYtoyI
FHDIxwhCcM1YEj1tqxpoNuaYzWxbBY3afPPNLsGJgM20OPUlD+kDmhunV7LyidxW
FW5Yp0vrMvbtBr9VGmtDahPoxpdO8Q==
=qZSa
-----END PGP SIGNATURE-----

--004SQJl7509giZyq--