Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 06 Apr 2022 20:05:23 +0200
From:   Michael Walle <michael@walle.cc>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Daniel Scally <djrscally@gmail.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        =?UTF-8?Q?Nuno_S=C3=A1?= <nuno.sa@analog.com>
Subject: Re: [PATCH v5 1/4] device property: Allow error pointer to be passed
 to fwnode APIs
In-Reply-To: <20220406130552.30930-1-andriy.shevchenko@linux.intel.com>
References: <20220406130552.30930-1-andriy.shevchenko@linux.intel.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <df3a78036864716fbeecf3cd94dbcbbe@walle.cc>
Precedence: bulk

> @@ -480,15 +485,19 @@ int fwnode_property_get_reference_args(const
> struct fwnode_handle *fwnode,
>  {
>  	int ret;
> 
> +	if (IS_ERR_OR_NULL(fwnode))
> +		return -ENOENT;
> +
>  	ret = fwnode_call_int_op(fwnode, get_reference_args, prop, 
> nargs_prop,
>  				 nargs, index, args);
> +	if (ret == 0)
> +		return ret;
> 
> -	if (ret < 0 && !IS_ERR_OR_NULL(fwnode) &&
> -	    !IS_ERR_OR_NULL(fwnode->secondary))
> -		ret = fwnode_call_int_op(fwnode->secondary, get_reference_args,
> -					 prop, nargs_prop, nargs, index, args);
> +	if (IS_ERR_OR_NULL(fwnode->secondary))
> +		return -ENOENT;

Doesn't this mean you overwrite any return code != 0 with -ENOENT?
Is this intended?

In any case:
Tested-by: Michael Walle <michael@walle.cc>

-michael