Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>
Cc:     linux-kernel@vger.kernel.org,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH v2] x86/apic: Do apic driver probe for "nosmp" use case
In-Reply-To: <20220406185430.552016-1-sathyanarayanan.kuppuswamy@linux.intel.com>
References: <20220406185430.552016-1-sathyanarayanan.kuppuswamy@linux.intel.com>
Date:   Thu, 07 Apr 2022 00:50:56 +0200
Message-ID: <87mtgxzuzz.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Apr 06 2022 at 18:54, Kuppuswamy Sathyanarayanan wrote:
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index b70344bf6600..79b8b521981c 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1419,22 +1419,22 @@ void __init apic_intr_mode_init(void)
>  		return;
>  	case APIC_VIRTUAL_WIRE:
>  		pr_info("APIC: Switch to virtual wire mode setup\n");
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_VIRTUAL_WIRE_NO_CONFIG:
>  		pr_info("APIC: Switch to virtual wire mode setup with no configuration\n");
>  		upmode = true;
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_SYMMETRIC_IO:
>  		pr_info("APIC: Switch to symmetric I/O mode setup\n");
> -		default_setup_apic_routing();
>  		break;
>  	case APIC_SYMMETRIC_IO_NO_ROUTING:
>  		pr_info("APIC: Switch to symmetric I/O mode setup in no SMP routine\n");
> +		upmode = true;

Why? The changelog tells nothing about this change.

And it's not correct because the APIC configuration is there, otherwise
__apic_intr_mode_select() would have returned APIC_VIRTUAL_WIRE_NO_CONFIG.

Thanks,

        tglx