Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test
To:     Matthew Wilcox <willy@infradead.org>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220405214809.3351223-1-sidhartha.kumar@oracle.com>
 <YkzDoBUAhydtvnR0@casper.infradead.org>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <bc04ce83-eed8-f35e-9816-bdd9d0ac1470@linuxfoundation.org>
Date:   Wed, 6 Apr 2022 13:38:33 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YkzDoBUAhydtvnR0@casper.infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/5/22 4:33 PM, Matthew Wilcox wrote:
> On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote:
>> -		perror("open");
>> -		exit(1);
>> +		switch (errno) {
>> +		case EACCES:
>> +			if (getuid())
>> +				printf("Please run this test as root\n");
> 
> Shouldn't all these be fprintf(stderr, ...); ?
> 
> 

printf() is consistent with the other messages in this file. Either
works.

thanks,
-- Shuah