Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Willem de Bruijn <willemdebruijn.kernel@gmail.com>
CC:     Sasha Levin <sashal@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        stable <stable@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4.14 1/2] ipv6: add missing tx timestamping on IPPROTO_RAW
Thread-Topic: [PATCH 4.14 1/2] ipv6: add missing tx timestamping on
 IPPROTO_RAW
Thread-Index: AQHYSezApD9O9L2JBUO7kEbsphrFo6zjSdEAgAAAi4A=
Date:   Wed, 6 Apr 2022 19:47:11 +0000
Message-ID: <20220406194711.3apwre6dbzbtw3ou@skbuf>
References: <20220406192956.3291614-1-vladimir.oltean@nxp.com>
 <20220406192956.3291614-2-vladimir.oltean@nxp.com>
 <CA+FuTSdK4T7DBf9wi3GjXA6P9o+6X-7c5vh9V0BN40GwbKSeGw@mail.gmail.com>
In-Reply-To: <CA+FuTSdK4T7DBf9wi3GjXA6P9o+6X-7c5vh9V0BN40GwbKSeGw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V4VyWWZL+b/3ojtj9jh6CHCAe+DrZUSu8NwWjG94sAa7bSnmAcF2RMgzi+Fs?=
 =?us-ascii?Q?LXiypfOO1RhH6kzuiIHRBBZ604gJYUOC4SAG5i7BFfF8fIzFpRAztO7yccQB?=
 =?us-ascii?Q?zfbXfHRyUvHZsOcaI1lKEsGRtBjaWQGAJMFBRl7Rgt58rYr0qvqnGv4gUgsB?=
 =?us-ascii?Q?mXqCWjQCVlgcgosV0wJqSIv8M8vxVENLAqtFeELwg+pl6pTkXHMQ/MuctDLo?=
 =?us-ascii?Q?QPT+wirmDfGY2z5pk6mZVE9913eMsM40XzBSy1xwRK8kfxvaISep6UTedemT?=
 =?us-ascii?Q?1lFQsLkGzQVCvtYsfsYPf1dhOPttNlk7mDAoX7nWKhw19FZLlwHasZHrNuqS?=
 =?us-ascii?Q?kAq+qkPwIDu0dwBGrCK0Utmcw/VouC+drI5RCemuk5dcX5tLby/YBp+eWKZm?=
 =?us-ascii?Q?qrujjKJx2PVwozRiAyqbNX4jbE36GIec1rWqS032PSKcysYyIAzHFcvBbdVW?=
 =?us-ascii?Q?4tGFy0c3ElveM+xpFgRpkIZvfFi69ls+lJ4ubSMGhHEQmVXvmgc/oMlmtKyn?=
 =?us-ascii?Q?pY+YseZL/U44xxkz8LtCxKGyKTp1uEjfamf+ZSs2PEjeqSaiKlPz9t+x1iR9?=
 =?us-ascii?Q?KL31bqU8e7XzBxWs2PyFC6wXmF6QeDUj7ePmFMcANh8Bj7oizwqekvkkfdCU?=
 =?us-ascii?Q?M8+v8/t/KMTtkm1u7ewK5EI17EvMuOL5EfoMSynJ3QJKtXyAQIoAUazZhkCL?=
 =?us-ascii?Q?3KM8id/CTsd3KMOOTsVRszSOGmse0RiQeDYzrCRL9q5izvnezDhYmyuR0ZUk?=
 =?us-ascii?Q?aoS71tQdDAi0Z09VGUiGVxOh7YyD02F/54HHvH2i8CTqISnjqqDSte4+D7ME?=
 =?us-ascii?Q?E56BpNKhF5NidiLUCr4f6oMmhrVRsVVAYu8HU/CamhLZ1kQjVwNS9Phh6xL9?=
 =?us-ascii?Q?IMVGeE1qrJjlIPHstO2U3NQMkBg8l9p+QbMm4rNEHf43PWmqpLbuN7I4y0yV?=
 =?us-ascii?Q?W1bUzOuEGKK51H3e7yvAD0AQDiuQSvHYB80b/B3rtwP6LYTX9u+/5YR6fRBe?=
 =?us-ascii?Q?0slmnKGzo8cjRcFsJx38oJXDU4UPESJngkSQbceTCWN9UVmSF8n4nfPkSlwq?=
 =?us-ascii?Q?YhGrsopa/2dAKA213KpTC9aZYZfbp5ES6oivPZCSkeUHkid+2Of9q3gfKQLN?=
 =?us-ascii?Q?UXP42N9SnQmbL9Md2dmsOoQcIhWosnucZSGgj150M4iDXDr6AOEDDusliukJ?=
 =?us-ascii?Q?xgnJuaEpljOPep6OVnF1W+REk8rDZTGW2339Puq7pOniZuyOLv7C9DJeUG7U?=
 =?us-ascii?Q?7EHJv8Nh90pPoBmgxN9wfDu7KKszJAIQj7bsG1HvdT/UNTbYfNUJI6kTw4j4?=
 =?us-ascii?Q?YZ7zDGjJJQumJ2Mf7FmzRCDhpRXfSkxfgw6iiaz01o4qo1hphFCNWbQrekp6?=
 =?us-ascii?Q?lTSzRrpgFwQSqpmODo0+IvowDrYMUTVmjAM8+SRpUrj3XBjPTlzpHNPBQO9Q?=
 =?us-ascii?Q?CeGOAXGcg7q5E+QqcddyOAWjhxH0Y/JFdK/1N5BbHy6kuI/apEMNqtSzPD+J?=
 =?us-ascii?Q?k/mEfjQH4VFrEYk0H6GDb6Zu7LlA1MgmslAlcB+Ged75BIKe16M0o1wuaovP?=
 =?us-ascii?Q?MgZjP3rU5RJj/xi642yhBuWBb+hqaK1sgZLyzErG6lHo3WFV0aPjmby9DOUo?=
 =?us-ascii?Q?FH7CXm/UmYjoJALkmehwLR0DL++ZHBNUQR4aaDbLblqGJcvGQjaVI81XHlcF?=
 =?us-ascii?Q?+KdiVZu2Y4FZeNUBK2PnXzaiQibhj1sIc1xczLGwEo4XLxAxaStS2tGJvVOR?=
 =?us-ascii?Q?mbbyfBKqcoNqSDEm8gvFKbQFQIrphHA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AE5CF49071F6B247B6B440FEA8BBD1AC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c3f023e-a4b9-41f1-5bad-08da18063e48
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2022 19:47:11.9208
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g2N45xVCUBJez81u/0tguDi8iyikIekKPe/NJykAlx391YMJ9VJkweZAEaBd95wECyRrK2Pb3NyozKimdXeIdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7492
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 06, 2022 at 03:45:14PM -0400, Willem de Bruijn wrote:
> On Wed, Apr 6, 2022 at 3:30 PM Vladimir Oltean <vladimir.oltean@nxp.com> =
wrote:
> >
> > From: Willem de Bruijn <willemb@google.com>
> >
> > [ Upstream commit fbfb2321e950918b430e7225546296b2dcadf725 ]
> >
> > Raw sockets support tx timestamping, but one case is missing.
> >
> > IPPROTO_RAW takes a separate packet construction path. raw_send_hdrinc
> > has an explicit call to sock_tx_timestamp, but rawv6_send_hdrinc does
> > not. Add it.
> >
> > Fixes: 11878b40ed5c ("net-timestamp: SOCK_RAW and PING timestamping")
> > Signed-off-by: Willem de Bruijn <willemb@google.com>
> > Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> For 4.14.y cherry-pick:
>=20
> Acked-by: Willem de Bruijn <willemb@google.com>

Thanks.

> Might be good to point out that this is not only a clean cherry-pick
> of the one-line patch, but has to include part of commit a818f75e311c
> ("net: ipv6: Hook into time based transmission") to plumb the
> sockcm_cookie. The rest of that patch is not a candidate for stable,
> so LGTM.

Point out how?=