Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_0D5C6E0E160AA0702025FDFF35906EE69E07@qq.com>
From:   <xkernel.wang@foxmail.com>
To:     <paskripkin@gmail.com>
Cc:     <gregkh@linuxfoundation.org>, <Larry.Finger@lwfinger.net>,
        <phil@philpotter.co.uk>, <linux-staging@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <tencent_5AB92A7786438342357C5669E7BF0C249505@qq.com> <tencent_15C23F2EC8197361EE200714C54E78B45206@qq.com> <9c307f1e-aa95-08e6-3a01-825caba19a30@gmail.com>
In-Reply-To: <9c307f1e-aa95-08e6-3a01-825caba19a30@gmail.com>
Subject: Re: [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc()
Date:   Thu, 7 Apr 2022 10:03:49 +0800
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 7bit
Thread-Index: AQHFCzdkIZn1ahtT3bex/Ulo9ihwXQEIO4NAAgMPs9ys8c3LUA==
Content-Language: zh-cn
Precedence: bulk

On Thursday, April 7, 2022 3:22 AM +0800, paskripkin@gmail.com wrote:
> > -void rtw_alloc_hwxmits(struct adapter *padapter)
> > +s32 rtw_alloc_hwxmits(struct adapter *padapter)
> >   {
> 
> What about plain 'int'? I know that s32 is typedef for 'int', but 'int'
> looks more natural
> 

I agree with you.
Since the type of `_rtw_init_xmit_priv` is `s32`, I directly changed the
type of `rtw_alloc_hwxmits` to `s32` (they are neighbors in rtw_xmit.h).
In fact, there are many places where `s32` appears together with `int` 
in related files, so maybe we can leave it as a future work to make all 
of them a unified form.

Regards,
Xiaoke Wang