Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <34d773c8d32c8d38033aae7e0fee572d757e242c.camel@intel.com>
Subject: Re: [RFC PATCH v5 027/104] KVM: TDX: initialize VM with TDX
 specific parameters
From:   Kai Huang <kai.huang@intel.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>, isaku.yamahata@intel.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     isaku.yamahata@gmail.com, Jim Mattson <jmattson@google.com>,
        erdemaktas@google.com, Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Date:   Thu, 07 Apr 2022 13:51:38 +1200
In-Reply-To: <a1052ec0-4ea6-d5db-a729-deec08712683@intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
         <c3b37cf5c83f92be0e153075d81a80729bf1031e.1646422845.git.isaku.yamahata@intel.com>
         <e392b53a-fbaa-4724-07f4-171424144f70@redhat.com>
         <a1052ec0-4ea6-d5db-a729-deec08712683@intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2022-04-07 at 09:29 +0800, Xiaoyao Li wrote:
> On 4/5/2022 8:58 PM, Paolo Bonzini wrote:
> > On 3/4/22 20:48, isaku.yamahata@intel.com wrote:
> > > +    td_params->attributes = init_vm->attributes;
> > > +    if (td_params->attributes & TDX_TD_ATTRIBUTE_PERFMON) {
> > > +        pr_warn("TD doesn't support perfmon. KVM needs to save/restore "
> > > +            "host perf registers properly.\n");
> > > +        return -EOPNOTSUPP;
> > > +    }
> > 
> > Why does KVM have to hardcode this (and LBR/AMX below)?  Is the level of 
> > hardware support available from tdx_caps, for example through the CPUID 
> > configs (0xA for this one, 0xD for LBR and AMX)?
> 
> It's wrong code. PMU is allowed.
> 
> AMX and LBR are disallowed because and the time we wrote the codes they 
> are not supported by KVM. Now AMX should be allowed, but (arch-)LBR 
> should be still blocked until KVM merges arch-LBR support.

I think Isaku's idea is we don't support them in the first submission?

If so as I suggested, we should add a TODO in comment..