Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp154952pxb; Thu, 7 Apr 2022 01:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxER/T4fobZvrpChKFx8Oh0/lILbrWLnIM4DhDrug3Uec8PKqrValSf5XXm/usQyFAvwUp0 X-Received: by 2002:a05:6402:3689:b0:419:d380:ddbc with SMTP id ej9-20020a056402368900b00419d380ddbcmr13059282edb.230.1649321113645; Thu, 07 Apr 2022 01:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649321113; cv=none; d=google.com; s=arc-20160816; b=W+klrL7RFBKZjz29gGq2WCf3NeJ7nEfuVvr05l36TXHE+iGSHLaksoNGewKv1YmpKk MkobpDylsggaUUBo61dHMa11vLL+Hby3inLj6OK0k+AtUAcQDwc/xJXWf4au3rS/Yo60 YJDC6Bryxaa40X6FbMT7H97YIKuKrhnvYXasz3N1xfDNa25EHLbJRgL2N2vkxpFN6mqF DOhe/tq4RVEkcQxDCPoehLx3uT629Vf09l1rAfUTM/pAxa3lNI7EOeeJ5JHDC74Jy3fm ECSWpg2AgZ6BGrRO2P/7r18CSCNVsR2R/oowR9y851wEQHRxy28lVH2m9AuYnnTvfGBj +8LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zelM0W3roF2hyF5IfymbR30q0/P/DpF9Q12I1M+1k/o=; b=JxJajAA1z7vhghmNy4jb/idH1uQevpPJc62jfhB5nEivkaKFJR+W3m0lJ+LGwUlE+q C2RUj+Z/ea2CMepFtH9m+zHxFT9DfxXKDa79O29Cl45/E28IWrbfvxPJj1tu00EVAlnY 0jZ/SoiMurAIeOAOh11iANRGr+bi9kB5NWb4YaILqAzxa8Bk26n3b7KHTnaBprU4WE12 8f4lQ4QWyE/A+0whFcOBv84s14gsroEtIOe64cROzBFxUUzMq4o12GPAxOvCYQpBh7ZO Jjpg6TKOzK/Uld61P6oq09DZEVaKYph57f9JUydkFihSyUtr9KoqBW2N+Tv/x3x6003M iOzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DU87k1kT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170906230600b006dff5e2d28esi13720331eja.210.2022.04.07.01.44.48; Thu, 07 Apr 2022 01:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=DU87k1kT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240952AbiDGGRT (ORCPT + 99 others); Thu, 7 Apr 2022 02:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233185AbiDGGRR (ORCPT ); Thu, 7 Apr 2022 02:17:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D9C1EC9A8; Wed, 6 Apr 2022 23:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=zelM0W3roF2hyF5IfymbR30q0/P/DpF9Q12I1M+1k/o=; b=DU87k1kT9d2X5nqsU2v/XFoOZu 0fa4hJhHKNsQsEEWrgdP3Mdlwfllx/h+7zKSoH6OXOlpe7QGrlBHyVqZeZEeL/ngq157/GVDWQ+oz CM+KmdmZROokCN0nGPRGepcyo+cxjrV7XlsdXYXPDvjMDvJpJO+ibRl3C4VaLpXP2kRL9/i92HhIF F2GH5TOlLD5HN0KKQYhGOln/vVjeZAjY7ncDvnuukO5Rqoo+aQ8VBEOhZwGBqezHM7dCweRtxVZWC 7twZ8DZRyRtZPjyqpZImvVr4mYnv2QSv12KyKBHjv4sWmle0BbZS/gtVnWuoLP4p/tz0Wu+dURiyl DMLrq1+A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncLQJ-009dnj-SU; Thu, 07 Apr 2022 06:15:15 +0000 Date: Wed, 6 Apr 2022 23:15:15 -0700 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Cc: Jens Axboe , drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, Lars Ellenberg , Philipp Reisner , linux-block@vger.kernel.org, Christoph =?iso-8859-1?Q?B=F6hmwalder?= Subject: Re: [PATCH 3/3] drbd: set QUEUE_FLAG_STABLE_WRITES Message-ID: References: <20220406190445.1937206-1-christoph.boehmwalder@linbit.com> <20220406190445.1937206-4-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220406190445.1937206-4-christoph.boehmwalder@linbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2022 at 09:04:45PM +0200, Christoph B?hmwalder wrote: > From: Christoph B?hmwalder > > We want our pages not to change while they are being written. Please document the _why_. A commit like that will leave everyone looking at this code in the future rather puzzled.