Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp177016pxb; Thu, 7 Apr 2022 02:32:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJopzIHreGRlEaG4unuImtZ0vGwhJokhBH5PebYyJwoj2Qij93A68khLFhOMJjaWDP+I3b X-Received: by 2002:a50:d0c1:0:b0:41c:dc92:59f1 with SMTP id g1-20020a50d0c1000000b0041cdc9259f1mr13460489edf.109.1649323962431; Thu, 07 Apr 2022 02:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649323962; cv=none; d=google.com; s=arc-20160816; b=YquC4M3eguDGCOystTMmk3npjxKVf25cVldurVdxnDSajaLy8WJyD1Pr1oi/gzikmK 2fcE7n7TyS1ReLN+dXFu8Dk6XeTFoM53YUTFsLMMkImqHauCWPrIugV96jN05QDHpIbn Ry3yYAzAOgC/3Mxu4UKd766CZwm/8ActYAOWKqn5wVCSRiuhWlTD3jVq5NKQN64AP8sg 2rOjec3kCDMz6fqw4LRTi7uecuwm3hIlBq6ByhQCBvJqbGcjkOFwtmdS5DwAE67SmKMx CkqLAnSEAMaVh1s3Hf8N8NdnxsDO12iGty/Rh6chGtXrhWSQW8uZU+ZI/VxbbSQzY1gQ 1/Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xe6Wh61D0dwQPHufcErxm0z4ibDB+THnfb9jDNUjPFM=; b=pdAPt1YMyj1h3G1wMpkljsi4nviv164v/G5BViKNI/ZRI+xzR/Rvd+mDZUfeluojcc YGNGiYLPUAOuTDGjzkYJMA0X+s10WqvqpKQRVMv+EmYRBbRjnyW4f6KOd+vkO8L7SRNT QD3BVvrA9jonmJ88DRXSKRT197Yh95Zn20NJ7TJRht8/4lUyC4nNuX1ZDrRxXBi26mne aRBJ4LgmHMjzwtUj4Wh2G8Z6mX/6E3Dz15/63aLa6f5DNQQXMRAhGv3SrZ7T7C2Vwxr7 HIpKWhKcuV80YDIYq1QR3nBY4vIKgB/XpP3CgvMDn1KPWj/Sdyn+0gtyhJtzU6I3xqj+ 89Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LkkPADU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vj13-20020a170907130d00b006df76385b68si11921176ejb.8.2022.04.07.02.32.17; Thu, 07 Apr 2022 02:32:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LkkPADU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240890AbiDGFck (ORCPT + 99 others); Thu, 7 Apr 2022 01:32:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237986AbiDGFcd (ORCPT ); Thu, 7 Apr 2022 01:32:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD9A2F2; Wed, 6 Apr 2022 22:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xe6Wh61D0dwQPHufcErxm0z4ibDB+THnfb9jDNUjPFM=; b=LkkPADU1q8U/0mpL3Zb6QAn9os hxX9Dx4f/YFPryOx1G89Ukac7e+GnrZr6Vi7XptDrUVDdIoikVtZpwT5MhjVfjZxEPLqAB1riDhyb JZXA/S+ygmQFq1H64CEkLk2IXZuciM5lwrz2RsOHh1A+cOBallCX9RbVEHszGh2Ctev3pG9Vqq7f0 nQ2RiVfpMq/6XTvvdVEJ3XrwHrwPh0EeFYX4xaWlK+xCWvdVq4FCvofnTm5fWE2yKlPrgCDO0JcOG fZ8rHrx6AMQJGf003qWsVghyNQuae6pEVuMbIQW/ea2bLZCSy5pGWAcNfXXeMlZwT8qPSNiE+iKS1 th53VCdg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncKih-009YRE-V6; Thu, 07 Apr 2022 05:30:11 +0000 Date: Wed, 6 Apr 2022 22:30:11 -0700 From: Christoph Hellwig To: Jane Chu Cc: Christoph Hellwig , "david@fromorbit.com" , "djwong@kernel.org" , "dan.j.williams@intel.com" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "ira.weiny@intel.com" , "willy@infradead.org" , "vgoyal@redhat.com" , "linux-fsdevel@vger.kernel.org" , "nvdimm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "x86@kernel.org" Subject: Re: [PATCH v7 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops Message-ID: References: <20220405194747.2386619-1-jane.chu@oracle.com> <20220405194747.2386619-5-jane.chu@oracle.com> <196d51a3-b3cc-02ae-0d7d-ee6fbb4d50e4@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <196d51a3-b3cc-02ae-0d7d-ee6fbb4d50e4@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2022 at 05:32:31PM +0000, Jane Chu wrote: > Yes, I believe Dan was motivated by avoiding the dm dance as a result of > adding .recovery_write to dax_operations. > > I understand your point about .recovery_write is device specific and > thus not something appropriate for device agnostic ops. > > I can see 2 options so far - > > 1) add .recovery_write to dax_operations and do the dm dance to hunt > down to the base device that actually provides the recovery action That would be my preference. But I'll wait for Dan to chime in. > Okay, will run the checkpatch.pl test again. Unfortuntely checkpatch.pl is broken in that regard. It treats the exception to occasionally go longer or readability as the default.