Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4957c527-3346-104e-0265-8231be093d1f@redhat.com>
Date:   Thu, 7 Apr 2022 11:09:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RESEND RFC PATCH 1/5] firmware: sysfb: Make
 sysfb_create_simplefb() return a pdev pointer
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Borislav Petkov <bp@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Miaoqian Lin <linmq006@gmail.com>
References: <20220406213919.600294-1-javierm@redhat.com>
 <20220406213919.600294-2-javierm@redhat.com>
 <Yk6o2MzkMQeSAcsb@phenom.ffwll.local>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <Yk6o2MzkMQeSAcsb@phenom.ffwll.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Daniel,

On 4/7/22 11:03, Daniel Vetter wrote:
> On Wed, Apr 06, 2022 at 11:39:15PM +0200, Javier Martinez Canillas wrote:
>> This function just returned 0 on success or an errno code on error, but it
>> could be useful to sysfb_init() to get a pointer to the device registered.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> 
> You need to rebase this onto 202c08914ba5 ("firmware: sysfb: fix
> platform-device leak in error path") which fixes the same error path leak
> you are fixing in here too. Or we just have a neat conflict when merging
> :-) But in that case please mention that you fix the error path leak too
> so it's less confusing when Linus or someone needs to resolve the
> conflict.
>

Ups, I thought that had my local tree up-to-date but it seems that was a few
days old. I've updated my remote now and rebased, so will have this fixed in
the next revision of the series.

And this patch becomes smaller indeed :)
 
> Anyway Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 

Thanks!

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat