Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220407105724.308930-1-hpa@redhat.com> <20220407115133.GL3293@kadam>
In-Reply-To: <20220407115133.GL3293@kadam>
From:   Kate Hsuan <hpa@redhat.com>
Date:   Thu, 7 Apr 2022 21:17:38 +0800
Message-ID: <CAEth8oG_GAuammtSqKzyj+Vq6ZsQJJOEeFhgxYhxXHViDYvkow@mail.gmail.com>
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, Hans De Goede <hdegoede@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Dan,

On Thu, Apr 7, 2022 at 7:52 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> > A not calibrated x_start setting would result in an incorrect AWB location
> > configuration on a sensor when only the rightmost stripe is used. x_start
> > should be calibrated by subtracting the stripe offset to set the coordinate
> > to the correct position on the second stripe.
> >

>
> I wish the commit description said more about what the bug looks like to
> the user.  This is the front facing camera, right?  Is part of the video
> blank or what's the deal?

This is IPU3 image processor. I tried to fix the configuration issues
on stripe 1 coordinate settings.

>
> > Signed-off-by: Kate Hsuan <hpa@redhat.com>
> > ---
> > Correct the patch. The correction should be awb, not awb_fr.
>
> I tried to review the original patch and it was impossible.  I saw
> you're from an @redhat.com email address so I decided it must be right.
>
> I kind of get that you need to be a domain expert to review these
> patches but this function is such a mess...

Sorry for the misunderstanding in my comments.
Since I made some mistakes on my v1 patch, so I had corrected this
part and quickly sent the v2 patch. You are welcome to pinpoint the
errors for my v2 patch. I could fix them.

Thank you.

>
> regards,
> dan carpenter
>


-- 
BR,
Kate