Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Apr 2022 01:11:09 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Yuezhang.Mo@sony.com" <Yuezhang.Mo@sony.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        Namjae Jeon <linkinjeon@kernel.org>,
        "sj1557.seo@samsung.com" <sj1557.seo@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "Andy.Wu@sony.com" <Andy.Wu@sony.com>,
        "Wataru.Aoyama@sony.com" <Wataru.Aoyama@sony.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v2 1/2] block: add sync_blockdev_range()
Message-ID: <Yk6cnX5eHrJYrVXQ@infradead.org>
References: <HK2PR04MB38914CCBCA891B82060B659281E39@HK2PR04MB3891.apcprd04.prod.outlook.com>
 <Ykp5cmdP3nV8XTFj@infradead.org>
 <HK2PR04MB38910663E1666A0C74A5618781E79@HK2PR04MB3891.apcprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <HK2PR04MB38910663E1666A0C74A5618781E79@HK2PR04MB3891.apcprd04.prod.outlook.com>
Precedence: bulk

On Wed, Apr 06, 2022 at 10:21:15AM +0000, Yuezhang.Mo@sony.com wrote:
> > From: Christoph Hellwig <hch@infradead.org>
> > > --- a/block/bdev.c
> > > +++ b/block/bdev.c
> > > @@ -200,6 +200,16 @@ int sync_blockdev(struct block_device *bdev)  }
> > > EXPORT_SYMBOL(sync_blockdev);
> > >
> > > +int sync_blockdev_range(struct block_device *bdev, loff_t lstart,
> > > +loff_t lend) {
> > > +	if (!bdev)
> > > +		return 0;
> > 
> > This check isn't really needed, and I don't think we need a !CONFIG_BLOCK
> > stub for this either.
> 
> sync_blockdev() and related helpers have this check and a !CONFIG_BLOCK stub.
> I would like to understand the background of your comment, could you explain a little more?

sync_blockdev and sync_blockdev do that because they are unconditionally
called from sync_filesystem, and not just from block-dependent code.
Eventually that should be cleaned up as well, but please don't add it to
new code.