Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 7 Apr 2022 16:26:09 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kate Hsuan <hpa@redhat.com>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, Hans De Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used
Message-ID: <20220407132609.GN3293@kadam>
References: <20220407105724.308930-1-hpa@redhat.com>
 <20220407115133.GL3293@kadam>
 <CAEth8oG_GAuammtSqKzyj+Vq6ZsQJJOEeFhgxYhxXHViDYvkow@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEth8oG_GAuammtSqKzyj+Vq6ZsQJJOEeFhgxYhxXHViDYvkow@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ibFzmUCv4mKsvdzNJyfCCk9FNJa7ZJ2nTkM/g67IAodpO+TweixKkU55B82X?=
 =?us-ascii?Q?HVjdF1AV4kDPaNqfaR2ngg6FuGpFhmWckFmHMRZ+vTjLp/FATRPa6XFubxCG?=
 =?us-ascii?Q?F5wDRDz1XEMrmVsHW3N6oct733YSqEvF1NGg/jJ38L4EUtvLuQ9vkbciX6D9?=
 =?us-ascii?Q?cC6rh570+tXvS0vsP2ng+YZ0rtPqpvX189vQwwKQe9gsQQ5ZfjpTrY9j05C3?=
 =?us-ascii?Q?P/lrG55hjuLyo9NDvIMhrixy8BloOW3MAtHQ1I2zc5ayZvylZopfeaflLtah?=
 =?us-ascii?Q?iZWbSMoJOymscGCs7J8SthVXJuy5NhopZd7noYx9+FE1JhsAOp2DvRLu8pHR?=
 =?us-ascii?Q?Lf3eL2VtuWucaVchSpeLP1Tek0lH0rNuh5gBXyrqSTN1GlU2eYlI5Bm9gX24?=
 =?us-ascii?Q?Mqf1EoNPYuZwU9B0dlZPnL/1OdN91yb6jcT7QQkNvvbQgqYi4tuVPxuzAKM7?=
 =?us-ascii?Q?pNwiDbeE6Q6CliJhzK66EAXN0Jgw75w/T23cL4hrOmCW6M4jWt+h+tUpldPQ?=
 =?us-ascii?Q?wnN7jNIB3XDt6Ie4/nnDp+FFzw63DjNEGqqbVHrs+EJaDbEekW5yTze/FPnh?=
 =?us-ascii?Q?UzrnfmIZgd2UC+22ocxFO9pWWTkFwAzHU/7lyc7psEdus/SdLGYkB5shbUu9?=
 =?us-ascii?Q?ylMYtNiPilZe03n18GnFhQh7iLQpf1siS9/fJNABzhYKxOfEljAe28iTKU6g?=
 =?us-ascii?Q?2xRgapGR2cjp9R+40FDDrU0edz2O1Lbj7FS7mOSwxKPpefjexinKte0RTjQw?=
 =?us-ascii?Q?X6L3m+LaUlVq8iwBgTt+ObaPJ0nhK0cwH+8sMuA96Pe13cZ7yT/wu8bp3m+H?=
 =?us-ascii?Q?2mjlExAgWOUuPzKHwk555iSWtlQS+1ZC2d7Z+bjau2YG0grBlmydGV2GKGbB?=
 =?us-ascii?Q?vMpXp9BNnLGPqiyyGIo9QXGPJeiUb3cToRrugIUtRvvDv7Z3A0uHWirTJvzy?=
 =?us-ascii?Q?Q1X464a7mFStAVwXYTi0pB1ewIjsyUScI6swpy6FbslITsUc1c0GqNstKaFb?=
 =?us-ascii?Q?7t5xchISeuJCE8OxZy2/Qf5fmPfDp1s0r7l7px0pMVb1YOj3BGxQRmJulIS2?=
 =?us-ascii?Q?XuC/n+av0EEzHEuPsWkU1vpy/zNnB4Lc6BSKVx4tP4WXCuZSavTB2ViJop8/?=
 =?us-ascii?Q?xWbx0tX8Mgg5ARRTeiDaGEFESidlxuGqMTJrcJqJ45gy3WC/WRurq6BmsZUu?=
 =?us-ascii?Q?n1lrnceLTQG5wP0qm7iNVCPfw+Sw2WiQXYhLq3fOKYXicURU98zM67sJnONI?=
 =?us-ascii?Q?neWRqpL0+YBum2mo8akH/abiXs6QmPUrPoUTxrD49fim9wpdSUfWU8d2cur0?=
 =?us-ascii?Q?P8qgzK9qT+caTSy96OsjIf27ZS8qoCXeo5bcFTNM+sa7ucG6Dkke9VKau7DM?=
 =?us-ascii?Q?53xDNPI+e5to9vHx3crJPEN4IiGf1ygixTjw1RxDDAwDFN4OivtY359AopeU?=
 =?us-ascii?Q?aGtEgzYJSlEEO4tcuvwtWTvZ4hE4/7DqfZllC5HPKXVuIccM75kp0qJY1jX/?=
 =?us-ascii?Q?m/PWN5K3xXPZXQ0T7Ly6HbV81A43MGJ/F50Aq8jeAsvvjuDBdoiSFgSYMJU6?=
 =?us-ascii?Q?Maiczga/ryGnatzAEpt8waCMTUx0WpEN7Iu46AyFSAfcMEuyEVpad4LcJiZR?=
 =?us-ascii?Q?ISHVtZsaAPki9+aGWoW1HAr4P6eRTtUEFLvl32eZOyvJ12gbio9irZqdqkbc?=
 =?us-ascii?Q?8qlL06y7QS4VEJrma7LJ6JNN8Huwd3uFKh88CFgKB5rmG+K2hP+mKriAtdwy?=
 =?us-ascii?Q?PejmIKQcXyEsGxpO0qBZHJXBIopB96s=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ce3afd9-4f7e-4370-93e0-08da189a3c9f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 13:26:35.1061
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GTGO+PTg0DatZg68uV9qOmOAVN6nVl7xJp00NzuqpY1jAfwdHQ+c4X/m3B7BW2F8pbluRTao/TOsc0dSVYhKN2k4lfsMJvfZUK8EUvcrSqM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5709
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070064
X-Proofpoint-GUID: sBtpC4SsPmNbRwWcf0qRszhTBjpahx8o
X-Proofpoint-ORIG-GUID: sBtpC4SsPmNbRwWcf0qRszhTBjpahx8o
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 07, 2022 at 09:17:38PM +0800, Kate Hsuan wrote:
> Hi Dan,
> 
> On Thu, Apr 7, 2022 at 7:52 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> > > A not calibrated x_start setting would result in an incorrect AWB location
> > > configuration on a sensor when only the rightmost stripe is used. x_start
> > > should be calibrated by subtracting the stripe offset to set the coordinate
> > > to the correct position on the second stripe.
> > >
> 
> >
> > I wish the commit description said more about what the bug looks like to
> > the user.  This is the front facing camera, right?  Is part of the video
> > blank or what's the deal?
> 
> This is IPU3 image processor. I tried to fix the configuration issues
> on stripe 1 coordinate settings.
> 

So in terms of users, if you configure it in a certain way then it
crashes?  What happens in terms of what the ordinary user sees?

regards,
dan carpenter