Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 7 Apr 2022 14:51:33 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kate Hsuan <hpa@redhat.com>
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when
 rightmost stripe is used
Message-ID: <20220407115133.GL3293@kadam>
References: <20220407105724.308930-1-hpa@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220407105724.308930-1-hpa@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5vHd+mS5IpGD0Oj0KCIgycER6JFigloVGq4JwP11QaaVBC9VAdDGfzOEG4jt?=
 =?us-ascii?Q?UKlF/6/Hc2FzRHWK51O/tbjugtNA3z5XQpLDOYxk/meQuLQhPCB1/XSphcXa?=
 =?us-ascii?Q?rt6lN58lMXz7acHp8ciJB/HzI1LIhYOVnUMQWlM8b19OV2jd1YkesWtKyRAi?=
 =?us-ascii?Q?c3P/LcV3tRysxcNb8nFFnB0axYmkaAwagWcK9bcDOoVyScw/GCWDitjp6tA2?=
 =?us-ascii?Q?RUnDBWH7b00Y3JT4h/Wkd1oD1TZhmQL2PBHhaC2LACnjB0DBh48YFt8rI1rg?=
 =?us-ascii?Q?h8DJZEYl5QidRnuSDaz7GuW8gZraMSEnT203Sn3tNYULeZTdcQxc9Y5cpA07?=
 =?us-ascii?Q?BnfIIHLUbUEYfUlVjo1aW7Iooqxfl5cYR7gTLcwzQGpZ2Y0rNGZkFsiBYejS?=
 =?us-ascii?Q?PXD+f2qYgCJ4GrbNa254+94X5N+kqyzc0yoQ6w2sH/xEqh8QDO2wgImjic5B?=
 =?us-ascii?Q?cdvSoTmXlDyPjfdZ7YP4z60AqaGlOnhxWWydLc35nIudUtM/+ECZDaa8OcuY?=
 =?us-ascii?Q?uwwqlkTfp0gEBF2YntT9ID6iI86kJiC20guOdXJb8VSBpVyS93bvG3vG2xLJ?=
 =?us-ascii?Q?oWsPc6DOecu3zeIIrOLUau0ZvM5NzclGQi1R/vx+pspMGR5J2jHNNAAhrdRL?=
 =?us-ascii?Q?xEZfO1SQZ+Oyy5neVIw2EO3q3qZB/zqamzRvCqh1/WiAaC4fQrT8Dop1VePS?=
 =?us-ascii?Q?EOqB7SaKAR+UE5IP7AGE/qrrvQqqFJ3lEou1PZYw4lmNhl3uFunC+JnK/wxB?=
 =?us-ascii?Q?NmthlyZ7i/G3PCHctrBTX479zGZmSecWgT2v3uFc1p91CRgq8ynvjOw9BQ6j?=
 =?us-ascii?Q?MU6UAjT8qxc5bHCx4SrxDVpm0LGydMp80baj09X1BhoHndT/bpm5aHLyo2NQ?=
 =?us-ascii?Q?YdGLxAEFnb6pnDqucKEYxTGFL5IBYZKy1y/OnQmhWcwbnNFQPhLfzhIj2nZu?=
 =?us-ascii?Q?xdBoMHEt6QFAmluBtg7RfTiHiBQc//86b4Fwd8R3KwfaJsorkWMbQzrGseip?=
 =?us-ascii?Q?cgIMgpXEHVqCWLOKMgYR70x+h5uc06dAAmv3E0TusOfHlmvOLNzbk9eCdwyD?=
 =?us-ascii?Q?VtIpkmyWqTHJZ8tv9jCXspPtHWCTfSRg3ua1gt+PSkgpcLY52lvxIlBT0Zke?=
 =?us-ascii?Q?JQ4shqxNPisfwkXhHBdVut7ppgRly0ako61OZFhrQOE/gpkrxYW/W/60Zslt?=
 =?us-ascii?Q?OLp9I6ixiCL2yZRCO4UtVYArtipQq1YTEHF3AaMG0jbE6+gnplbTacg7VB7e?=
 =?us-ascii?Q?XDvvRr3UQ5/3ODR1BNgUfQF+6RMb5km0TXZS5gYihzb0UR1/ijnhLk/1S1bf?=
 =?us-ascii?Q?R1PkUwSsdQU7HATSeMmiBiZP4j7WkyLj5YkHa1ByGdkMHaTTzU/v4pK8A/nN?=
 =?us-ascii?Q?hjQvNO1uhhw220PE0ACcfJ4g/s26dHcYQcQSZc7Dr9x1f+VDENFz/EZdyZbS?=
 =?us-ascii?Q?Ea6stQ0C3T6uoAEeVhXm15Y4t4HG1NgV+rqV6C3x4Aso0e77znt378uYSNzW?=
 =?us-ascii?Q?T2mKCtRJgA4PjVN1vDzGBEzdxdpqd5XWqIMH/kRRp08a6bTS2bqtcfBlnZdq?=
 =?us-ascii?Q?J6KcZxQoAhUbbAiNmNn63qsjO8oNATgS1O4g1HKcL8zuLqbxKKf3clJtuCZr?=
 =?us-ascii?Q?WnOYXMbFmU+WnVq3hVkW16s1NmTHkK55Zm4I2zDIj7//vp74eX8TyT8AJS8R?=
 =?us-ascii?Q?ikSKnn25Pg2ToFDYN68HEfDukoGlYDYxOF3V3RNCtcWBKtNQ7Uel2TrgHvXY?=
 =?us-ascii?Q?JGoDl9/JsQJZLmybdj2h5YmZ+9PFdT8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5279e45d-4a29-4a79-06db-08da188cfd18
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 11:51:44.9232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AKuWi3V5TmoiCYkOq6P9B1TYAaCyQd5NB7CZl/pdrQxZFstgxh6wa8Ssw9kwx1TysNGC2dtJ6LOXqta57c7WEKZdL50wXrWlvPI3QhJuJKQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4622
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204070059
X-Proofpoint-GUID: 27PlgZ69D5V2ZPQvgw6fbEOWPDSDb-eW
X-Proofpoint-ORIG-GUID: 27PlgZ69D5V2ZPQvgw6fbEOWPDSDb-eW
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> A not calibrated x_start setting would result in an incorrect AWB location
> configuration on a sensor when only the rightmost stripe is used. x_start
> should be calibrated by subtracting the stripe offset to set the coordinate
> to the correct position on the second stripe.
> 

I wish the commit description said more about what the bug looks like to
the user.  This is the front facing camera, right?  Is part of the video
blank or what's the deal?

> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> ---
> Correct the patch. The correction should be awb, not awb_fr.

I tried to review the original patch and it was impossible.  I saw
you're from an @redhat.com email address so I decided it must be right.

I kind of get that you need to be a domain expert to review these
patches but this function is such a mess...

regards,
dan carpenter