Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <91ed3c18-6cff-c6d4-a628-81f1f71b21dc@amd.com>
Date:   Thu, 7 Apr 2022 09:57:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Cc:     brijesh.singh@amd.com, Ingo Molnar <mingo@redhat.com>,
        Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v12 29/46] x86/boot: Add Confidential Computing type to
 setup_data
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org
References: <20220307213356.2797205-1-brijesh.singh@amd.com>
 <20220307213356.2797205-30-brijesh.singh@amd.com> <87v8vlzz8x.ffs@tglx>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <87v8vlzz8x.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWpGdE5HMUo5T3pUSDc2R1BINDdFUVJ0a2xyTWFCSFVld05xNlEyTmJVTVNC?=
 =?utf-8?B?SzVuc0hWM0t1Q2lqL0paN0RNTE5kT2FMNm00NjZPKzgvYWUzSFEzNUZVMHFF?=
 =?utf-8?B?bHEyd200RmVRam4yZU9HSjIxTWt3bWJMTXdHcmJGVXhGYm5hdHdnOTVSZ2Ju?=
 =?utf-8?B?RW50eTdPQzJCd1RXTTlJMytra0dmUml5Y2pPZ3B6TzMzYWJCaTJUUVNST0pn?=
 =?utf-8?B?aGhLN2l3VGJnQXYwQm5FbUZuclk0Wm9aVmRHNHVLSU4vS3Foa0pyZE5oUkxP?=
 =?utf-8?B?bnNCczNsbHlKZGQvWDcvRUJpT1FWT0QwSzluNGp0R2RJUS92eTMrcVhhMzYy?=
 =?utf-8?B?VlNlZk5Lbk9TbzB1OW8wdFJOUnY2WHZGRzY4MHZQckl4SnZObjVTWkxHVkRl?=
 =?utf-8?B?ZE9MNkxrVTNYOVdIVlFWbUsrRUtSVjdqOEFiZDAxSGJ6ejNNK1lhS3hTSGlx?=
 =?utf-8?B?WGtJRGc2ZlBrU2VmUHM1ZGh4NG96UE1ndjBaTHo5ZHlkVU1VVVdBVkhCd21t?=
 =?utf-8?B?WDZMWkt5VnFLN3V0aGpDSmdwaGxVU2hiR0ZqWUluWDRGSHNWaVpmNnJ2dXMr?=
 =?utf-8?B?UEtCOFhuZ3VTU1lKNGRPbmgxb2JwWWxZWGtBRVAvbnM1YjFyUTRUbkNlaFEv?=
 =?utf-8?B?cEgvNGMyd09xVnVzejBKVS9BRU16RHp4M2JpN0p4TEt6RzAveUdiRlB3bEhk?=
 =?utf-8?B?MkFIUXFXcXlUK2ExWm8wbUsxdi9PUE4raHhxTUFzbStCU011VU1BOGpDTFlv?=
 =?utf-8?B?R2xzVXNjS3RiK1hnYXFhdS9VQzc5cXF6UDl5b0kxTXdON2JubEdRSW4vY2VS?=
 =?utf-8?B?Wjk0c1FScFozT1lFall6NkJiVGVXWVJ3Qi96R1pDNE1tVTlKamRCb3NjdVMv?=
 =?utf-8?B?aVQvSlJackdhdmxKWjlqQ1FZQTZsMURRL2Q0UDRUVnl5Mk1mWjgwWGVBNzNr?=
 =?utf-8?B?S0JteTQyY3FCOTg2YnpTV3gzTVdUcjZRQ2NnQmVXZXRScE03eFNSRXhRV2ww?=
 =?utf-8?B?VjZ4STZuSEsyRVB5RVROT1hya2RTSkVlQVBsWHh2bEg0TjRSUkxpdGlTZDJ4?=
 =?utf-8?B?Zk5aU3c4TEkxalpWd0xrbXVZblFhUnY3Ry9QQldlVWliS0JPdXd3Q21lV1ow?=
 =?utf-8?B?YUFQc2RaY3gvNkZNOWVQYmhxai9MdVZwV0NjOGZuL3RNQXNIckVBalBHK1FS?=
 =?utf-8?B?VDRaUWZhS2dnNDhERGlTQVBzNDNhOU5GbE5teUMzeThRV2Z6K0FqNTFQM05E?=
 =?utf-8?B?WFFIMmYydW5KdkN0azUvdGJtMi9RaTlxUFNLcU56YnhLZVBMK3NGSXVoUmxK?=
 =?utf-8?B?Y0dxbG1VR3V3Z1kxZXVKMVpIRERta3BZOVVHWTQwcS9VWU1hYmMzVUwxQ2Rz?=
 =?utf-8?B?eldhMnQzNGh5MTIreXlBM3RLU1NJVTNSVUF6bGZ4SzlhaStPelBQa2NaVTF0?=
 =?utf-8?B?TjVsVkFWOEFHQXVFVGRPMDVqWGtuVUxFNW91amRrMFV2QjhQQ1pMaXBsOGdm?=
 =?utf-8?B?Z1RlbXUvTlV0WXI2V1RxSnZoSmhUZHJXN014UkNpbi84aElhamlMZHcxWE1B?=
 =?utf-8?B?NENnOGQvUkhwVVk5ZXdQU21DaENEcGtBVE5iVHBlS0pjZmNKUGl2T05vNXVB?=
 =?utf-8?B?UGRnWDlTMU1SR1FrcWQwRnlzNmVzcVdJWXoxckFRdDRvL0dFWkhwYzdmdDFW?=
 =?utf-8?B?ZDFYdWRVSWYveUFTNzkybUlnWGg1YzYwS1pRVFc0c1lZVmNBRFZxY2lVRXAy?=
 =?utf-8?B?bW5hU1dOTm9OSlNIV3YyVVh6NFpoQ29DczJBbW9LLzliMElFbktBQUNzNlgw?=
 =?utf-8?B?MzZBWllPMW03R01iRFYrMkg5eVdiVVVKdllYZExDZ2ZmV0NmNWFnYkNaVmEr?=
 =?utf-8?B?TTJsOVVTbjFvMGZQREdVWjdnbVFGTkxZZVFpWDVNK1daSGtmNnAxRkJYN2pM?=
 =?utf-8?B?VzB6dW5Rem9KOGt3Z0VpTXJSUFlQY2JsMEd0bWgyQVVaMGZsQ3FuR0I4Mmpx?=
 =?utf-8?B?UVZQVlJzemplSWJobkRGVVhaL3NraUlrbkNFVTRzUGFsdUZ1RTNRcVFGN3RZ?=
 =?utf-8?B?bWwwQmdreTB1YzVVbk50NHU0VU5VZHV2dnpKMmZUUFhyVDE0K2F6T1dEVVd6?=
 =?utf-8?B?QUM3NGFjeVZtSzFQR2l5RERsdlFycm51cGtlR3NGWmV5SnBmSGVvVXVuTkpX?=
 =?utf-8?B?NGFPUTUxVnlVemdrNi9pV0Z6VjlidTFYY2RFcGFaWWtSSmNnQU5JQTg0VDRh?=
 =?utf-8?B?WHdydzlpTmgyREtpQ2J5WStHUlBwNkc2dDd6bHpGZ25Ja2dDVmR6WXRwVEla?=
 =?utf-8?B?QmV6SitrMlNicTBCcGdMdlBMcEFVelhMTkNDZ05BM0lZMUxhOGhidz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9462e515-0a71-44fa-f611-08da18a6ee8a
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 14:57:27.4412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p9wgeYsQsh5n04T2pRtOqrPYxLsJIWfzAamT8NVDRl++28INLDZqsBZSS+0VkSBb7O5+9bPukQ/YdKAXCgaT6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5230
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/6/22 16:19, Thomas Gleixner wrote:
> On Mon, Mar 07 2022 at 15:33, Brijesh Singh wrote:
>>   
>> +/*
>> + * AMD SEV Confidential computing blob structure. The structure is
>> + * defined in OVMF UEFI firmware header:
>> + * https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h
>> + */
>> +#define CC_BLOB_SEV_HDR_MAGIC	0x45444d41
>> +struct cc_blob_sev_info {
>> +	u32 magic;
>> +	u16 version;
>> +	u16 reserved;
>> +	u64 secrets_phys;
>> +	u32 secrets_len;
>> +	u32 rsvd1;
>> +	u64 cpuid_phys;
>> +	u32 cpuid_len;
>> +	u32 rsvd2;
>> +};
> 
> Shouldn't this be packed?
> 

Yep, to avoid any additional compiler alignment we should pack it.

thanks