Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 07 Apr 2022 10:29:18 +0200
Message-ID: <s5hfsmp2t5t.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        kernel test robot <lkp@intel.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] sound/oss/dmasound: fix build when drivers are mixed =y/=m
In-Reply-To: <20220405234118.24830-1-rdunlap@infradead.org>
References: <20220405234118.24830-1-rdunlap@infradead.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 06 Apr 2022 01:41:18 +0200,
Randy Dunlap wrote:
> 
> When CONFIG_DMASOUND_ATARI=m and CONFIG_DMASOUND_Q40=y (or vice versa),
> dmasound_core.o can be built without dmasound_deinit() being defined,
> causing a build error:
> 
> ERROR: modpost: "dmasound_deinit" [sound/oss/dmasound/dmasound_atari.ko] undefined!
> 
> Modify dmasound_core.c and dmasound.h so that dmasound_deinit() is
> always available.
> 
> The mixed modes (=y/=m) also mean that several variables and structs
> have to be declared in all cases.
> 
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202204032138.EFT9qGEd-lkp@intel.com
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org

Thanks, applied now.


Takashi