Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <1649311250-17077-1-git-send-email-baihaowen@meizu.com>
 <bb7635cf-461e-7abd-6092-4be67099c846@amd.com> <CADnq5_Ogke7XuVsQaB8pskreXam1ASTE2jna=U6iuKuuyR4r-Q@mail.gmail.com>
 <CADnq5_Phw7SvfdtX_RN7N4xEzceYpZLvRv971y3YyOdrg5Lz_w@mail.gmail.com> <aac9a178-e58c-60c7-a9b5-56ce219d051c@amd.com>
In-Reply-To: <aac9a178-e58c-60c7-a9b5-56ce219d051c@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 7 Apr 2022 13:37:21 -0400
Message-ID: <CADnq5_Po6VDogC91SrUm1hL8Vin0HkKf0wv2VQ+pnJ4VagQu4A@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Fix indenting mistakes in dcn10_hw_sequencer.c
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     Haowen Bai <baihaowen@meizu.com>, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 7, 2022 at 1:32 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-04-07 12:07, Alex Deucher wrote:
> > Actually this just causes another warning.  Dropped for now.  More below.
> >
> > On Thu, Apr 7, 2022 at 11:52 AM Alex Deucher <alexdeucher@gmail.com> wrote:
> >>
> >> Applied.  Thanks!
> >>
> >> Alex
> >>
> >> On Thu, Apr 7, 2022 at 10:18 AM Harry Wentland <harry.wentland@amd.com> wrote:
> >>>
> >>>
> >>>
> >>> On 2022-04-07 02:00, Haowen Bai wrote:
> >>>> Smatch reports the following:
> >>>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2174
> >>>> dcn10_enable_vblanks_synchronization() warn: if statement not indented
> >>>>
> >>>> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> >>>
> >>> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> >>>
> >>> Harry
> >>>
> >>>> ---
> >>>>  drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 14 +++++++-------
> >>>>  1 file changed, 7 insertions(+), 7 deletions(-)
> >>>>
> >>>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> >>>> index ee22f4422d26..3c338b85040c 100644
> >>>> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> >>>> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> >>>> @@ -2172,13 +2172,13 @@ void dcn10_enable_vblanks_synchronization(
> >>>>       if (master >= 0) {
> >>>>               for (i = 0; i < group_size; i++) {
> >>>>                       if (i != master && !grouped_pipes[i]->stream->has_non_synchronizable_pclk)
> >>>> -                     grouped_pipes[i]->stream_res.tg->funcs->align_vblanks(
> >>>> -                             grouped_pipes[master]->stream_res.tg,
> >>>> -                             grouped_pipes[i]->stream_res.tg,
> >>>> -                             grouped_pipes[master]->stream->timing.pix_clk_100hz,
> >>>> -                             grouped_pipes[i]->stream->timing.pix_clk_100hz,
> >>>> -                             get_clock_divider(grouped_pipes[master], false),
> >>>> -                             get_clock_divider(grouped_pipes[i], false));
> >>>> +                             grouped_pipes[i]->stream_res.tg->funcs->align_vblanks(
> >>>> +                                     grouped_pipes[master]->stream_res.tg,
> >>>> +                                     grouped_pipes[i]->stream_res.tg,
> >>>> +                                     grouped_pipes[master]->stream->timing.pix_clk_100hz,
> >>>> +                                     grouped_pipes[i]->stream->timing.pix_clk_100hz,
> >>>> +                                     get_clock_divider(grouped_pipes[master], false),
> >>>> +                                     get_clock_divider(grouped_pipes[i], false));
> >>>>                               grouped_pipes[i]->stream->vblank_synchronized = true;
> >
> > @Harry Wentland should this last statement be part of the if clause or
> > the for loop?
> >
>
> It should be part of the if clause.

Can one of you send a patch to fix that up?

Thanks!

Alex

>
> Harry
>
> > Alex
> >
> >>>>               }
> >>>>               grouped_pipes[master]->stream->vblank_synchronized = true;
> >>>
>