Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <533ae31b-1794-f28b-a783-a356e9707ef3@amd.com>
Date:   Thu, 7 Apr 2022 10:17:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] drm/amd/display: Fix pointer dereferenced before checking
Content-Language: en-US
To:     Haowen Bai <baihaowen@meizu.com>, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <1649310731-15934-1-git-send-email-baihaowen@meizu.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <1649310731-15934-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TndyV0M4eTJWVVJJUkU2WGdDWmtuZ21hZWJoNE56TUhaMG4yNU5RcEM2WW1a?=
 =?utf-8?B?M1pWMnJieVlLL3VuclBWdUd2TUpGOGEzZ0RTZGJHOXRYRkJ6VWVRckNTRC9G?=
 =?utf-8?B?QjNqVFlNRUFySEllempxSHFUZ05HUStRTTFTK0pqTEtqcXFYbzI5RmJnS2xt?=
 =?utf-8?B?d3dlOEQ1eVBoblNKQXdlV2R4TnFUSVB4TjVwRGlMMENuRGdEMG9YMFVXMlNF?=
 =?utf-8?B?TDFHc29sL3ZGSjRvOXBxcnU4MzRnL2U3K1hpNWhUbm9WcEFuNEFod29SSjVP?=
 =?utf-8?B?QUVrbVlLNk16TklsS3pwSjR5dWQ1NVhqaWZaZDRGV3lqV0tnMEdqSmZHNTBY?=
 =?utf-8?B?L1h5QmJxYXg0WmNGazIzSldxNFdibVhQMHV5Y3U5Tm4wZ3ZhTUpYemZ1ZnRV?=
 =?utf-8?B?YVRoZ0JiY1RVSzdlbEZkaHBPeVI1Wk9PaXlHNHIxYlg4akNhTzZEanE0WG9V?=
 =?utf-8?B?S2J5bytnVStUb2loQTRGVllUWlBPWlZWN2NNVU5aVWpCajVtNGhwN2p3VUVC?=
 =?utf-8?B?VHo1ZVRveFM4aFNTM1NHZkNiYk1CQm1MdjdVSDE4Z05JRzdMb01HYzRjNzFQ?=
 =?utf-8?B?SWdYWVdweXloN3R1a3ZmUXh0T1B4V09rcGxsWDBlV3FrbERvMHRoS0ZWY0Nm?=
 =?utf-8?B?L0FRZGxWZjhDMTgxYmlPU0FtRkkwR0xPT09KSWM5dzZYV3ZFbGZTZkcrQzJ6?=
 =?utf-8?B?cmFuMWw1RTRQbmlGcG1KaVE0N3JDb2xXMUI0ZVZJdEpjaTVSaklCOEpGYkM3?=
 =?utf-8?B?QStpRFVxNjRVdG1LcXZYWDQyZE14bFRVcTVBTjNabmpNa1VaOFNtVXdjYm1x?=
 =?utf-8?B?bFc1dW05clFtWUpHanYzR3lCc1gxTmxRaXhCcUx2VGpJSzhPcEtBOEdFbHlW?=
 =?utf-8?B?aEx4S0pMTk5NWVRxK3p4TUdZZUp3UXNGTUNUMUNxQ0NKMFFnTTlxRy9BV292?=
 =?utf-8?B?MGxPZVNqeXFoVUY2VlJXMU1xZVBibjg1QjFmMXNLZU0ycWhwK0tia2xJcnRw?=
 =?utf-8?B?ZXM0WHVLWUVDK0VuSmQ1cG40SGZueC9ZOEVOUDkzNDl3NEx0eWdQL0lSVjFk?=
 =?utf-8?B?RStzZ1VPR08wWkh4VTJjdVZmckVzRzBGUWZ3T3ZxdkRsUzZ0R1gzNWJVK0py?=
 =?utf-8?B?dUx1RTdJVHZqakwrdGp2TlNYRFprTkhGUzdkblh1R0JRRHZHUjg1cG5JRU5K?=
 =?utf-8?B?UXZ6clF5UEMrYjZqMDhBWjlXTXVYSVpLZmdvYVkvN0VYRTNaUVNXYmJIcm1S?=
 =?utf-8?B?QVZUSkQvN3k2ZjlkbVJnY3VIZVJWOFZseE9ncXB0ZjRrNmt6aU1laGF3c1JJ?=
 =?utf-8?B?blh2SGdFYktZVkI3R2FZeVIwZ282TFI3OXBQR1EzUUxsOXcyMzVsV1BIYmVQ?=
 =?utf-8?B?OElRUWZ5WHJPM2VXS0FSTWNObXhuTnZEQlRBdWVMMms0MG13T0JTdzUzTmxD?=
 =?utf-8?B?K3REcVNXSE9xbzFyOXk3U1RMaWpxdUl2YUJXOG9Ra2J0RXBJaGVaNlkvWkZR?=
 =?utf-8?B?SDRGYXRBMlJPbjBOcUhSZkRydVMxRDErUms3b1lPMDhETHJKUE9xcXZ1b2xU?=
 =?utf-8?B?RVNZU0VuYTNMaWVCbStMWXN5WkJEY1paLzRKQ3VGSVRIMGZzUjRrVjdOVkps?=
 =?utf-8?B?Ni9pUnk0Z0Z2SkZWeEoxMjJUbjNOcFlqZm9PYXgwK29vQjlXVTRWYmt1d3lu?=
 =?utf-8?B?NFk4KzdNSUZlMHU5b2NHRjU0SmtNTFlsQ2RXUG5McmYrRmFGd3JtL2MyVXFj?=
 =?utf-8?B?dW1yUXhiVWlxdGoxUVQ5cGZuMG5WTDlDOFNMQ1VUenVSakxmNzN6UHdiQ2Fr?=
 =?utf-8?B?NlE2UXlmM1lENUYzRXM1WXN0eWpsQUFFVWVIZ0tPY252aFNDTDNPRzJMRHdO?=
 =?utf-8?B?SUxhNUIrVWZ2TDA5Z1lQTjdOREtMTnI2ZWJBYkZHckYrd255eGRiK1FsRnlv?=
 =?utf-8?B?cGtXQk53elpUMzU2ak1JSFJSdzk5RjR1R1hMRFIzOXgrUE9TTVNIWVBtUDJX?=
 =?utf-8?B?dXd1NkVXekdPZWVUN0hDekdTT3ZkVEorUEordzVLVDlQSWN5aGRRUXBVTVVG?=
 =?utf-8?B?Q0ZoL0VoSkxER1g1YmZxbnlTcXhpLzIxdW4rRzYyWGtFQXlNcVFZNlJPckVS?=
 =?utf-8?B?UFhBemdNdUFVK3ZySkt5TFIvTHBQQ3VPZktQT0RmSGV3dnZBekZheUhwN3ZT?=
 =?utf-8?B?T1F0Z20ydW03aUEzOGFiQUs5Z0JzYi9EbjNvTm92ZjJINmRkd3JBdG5seGZi?=
 =?utf-8?B?NllYNDhvWmpESWZjM3NjQUVENjc3bE1rc1QzYjJuUUZqbHFHV1gxb3FlRmhk?=
 =?utf-8?B?QjRUQ3pQdDEyd2RtMEg4c2I3Vm4rdDEyS1g1ZStjTGdxSnFzN2k4QT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba5dd892-1aad-4370-95f6-08da18a16b97
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 14:18:00.2431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iOuB2ltnvS4Dewoj99s3w1wZ619TqUISz/AB+8z2wlCq2S+pVOV+5evDj5o/IIF8sD1sPZdOw1g4ymQfHsUoDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2528
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-04-07 01:52, Haowen Bai wrote:
> The pointer dc is dereferencing pointer plane_state before plane_state
> is being null checked. Fix this by assigning plane_state->ctx->dc to
> dc only if plane_state is not NULL, otherwise just NULL.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index 50820e79d3c4..ee22f4422d26 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -3211,7 +3211,7 @@ void dcn10_update_pending_status(struct pipe_ctx *pipe_ctx)
>  	struct dc_plane_state *plane_state = pipe_ctx->plane_state;
>  	struct timing_generator *tg = pipe_ctx->stream_res.tg;
>  	bool flip_pending;
> -	struct dc *dc = plane_state->ctx->dc;

This has worked for years now, meaning plane_state is never
NULL here. It might be better to drop the NULL check below.

Harry

> +	struct dc *dc = plane_state ? plane_state->ctx->dc : NULL;
>  
>  	if (plane_state == NULL)
>  		return;