Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 7 Apr 2022 16:09:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Akihiko Odaki <akihiko.odaki@gmail.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Jaroslav Kysela <perex@perex.cz>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rt5682: Add jack kcontrol
Message-ID: <Yk7+jbQ0KBM0zVh9@sirena.org.uk>
References: <20220407141316.5099-1-akihiko.odaki@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dSCykcoLsRMrrTF1"
Content-Disposition: inline
In-Reply-To: <20220407141316.5099-1-akihiko.odaki@gmail.com>
Precedence: bulk


--dSCykcoLsRMrrTF1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 07, 2022 at 11:13:16PM +0900, Akihiko Odaki wrote:

> Create a jack kcontrol manually as rt5682 does not use DAPM pins
> for jack and will not have kcontrols for them.

Why not use DAPM for the jack?  Note that normally the jack is part of
the machine driver not the CODEC - there's no way the CODEC can know how
it's been wired in on any given system.

--dSCykcoLsRMrrTF1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJO/owACgkQJNaLcl1U
h9AEGgf/W3/sjKKCepOxRaMvpQ7VN2uIOJlDIBnK1XFdb4T1ujEE53raK3EDDf7g
a9FFb5FmG1ejbqW1XRe0OHqjuhUNWWu60gao+FhVFB0gdqhJo39i3IQ3Az1lwMDD
/rqeJtfWQMu01WQHkQkPY6Uw2pN2EaJlDQEd5g9r7RoU9GBqnY/+9ksFzFzdt6Cq
zhfjTEWqoVhCcY+ia3PM+BNGAcEl49mLoDyKn8TskVKSatVSEfqA+vq3SbmcnBXD
LwroN3WEfoD5g47ynxxLZIQ44E0lai1QQvpn8+Vuop01UE7Y5AnHwY+0vQ25mLE9
kAI5EKh7qZgRDm+SupMnx2KZ2KOb3w==
=q2D7
-----END PGP SIGNATURE-----

--dSCykcoLsRMrrTF1--