Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Xiaomeng Tong <xiam0nd.tong@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
CC:     "pabeni@redhat.com" <pabeni@redhat.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH] i40e: i40e_main: fix a missing check on
 list iterator
Thread-Topic: [Intel-wired-lan] [PATCH] i40e: i40e_main: fix a missing check
 on list iterator
Thread-Index: AQHYQqtWg9RkTjKkJ0Srnw1g2FXWpazkGL8Q
Date:   Thu, 7 Apr 2022 07:14:28 +0000
Message-ID: <BYAPR11MB33679D2463F0E8B3833CC64BFCE69@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220327063606.7315-1-xiam0nd.tong@gmail.com>
In-Reply-To: <20220327063606.7315-1-xiam0nd.tong@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kwYoqt4py8PKSIGrtjiUy/wfCBxcqkzQgGkiHI7UpbSg4PJw6yOcnaRYt8K4?=
 =?us-ascii?Q?CEDwiecqBW2kvabjPnHEgknm9jCbf0yXacmLk+CJtcZGxC640IbEHJF8f+Qt?=
 =?us-ascii?Q?h+Oldv67xRFJKP0KSoY8iWgmFbzOJop54UQdWCEQJmFaYjY9Xgl1E1d48e6d?=
 =?us-ascii?Q?aFkU6G2kdUZPd76rS8lT7RFpnrMCmt7oi1aF5cu8SFLK+chwEhr2Z3s3shgG?=
 =?us-ascii?Q?K69uHL1Hr6kmKnmltuQAzX2XHkAC9dxB4nhBfMI/XBmzGpjeQ+n1ffZoU1jM?=
 =?us-ascii?Q?v0tjKW39v2mnK+YcLMgmSlboPWLz1KS24Kfk5lPCP+lwtCbMSoao89mMMffq?=
 =?us-ascii?Q?gnsqrkILxP+yRkm9Ss4esV+3pEz37pR3FkJAoAcSQ9OIV/bAN+QOvCxg9tGM?=
 =?us-ascii?Q?Hz0QuPVg3PQFt8Xo78xXS2hpDYGIEfYvhbeDBbte/QDEHQmm0Ci+y5FzUd7/?=
 =?us-ascii?Q?+hBQz+/86FBM3je9Y8iPGZu/cRort5r9EAGr1z7X3q1q985AbvyP4y9Wi5Jo?=
 =?us-ascii?Q?mB1MzZsIBBg78GmxV2qeBoZCfa5ET53sBHVOZx2E8CTkFxL18KQHe/l1Mqll?=
 =?us-ascii?Q?bGDSzHVU8+Dbsvxdh30LfhFx4D1NLKdVWeSMIZYDdM+Ke/upwckaCTLiGKqo?=
 =?us-ascii?Q?f5Bo7f5ji4vcf0SFuTNngNlzdux4gIgE9YIVNQCYeeDc9qul2bPwWl3G4eio?=
 =?us-ascii?Q?2o+d6PnKiLOSBQpypiPi7mB+bmaYiKb1LuLrbkZsgIYfCfEiwzgazzZQmAOJ?=
 =?us-ascii?Q?By0rBCJPZy9hxZCWOQwI65fB2aGNvwvyg7EZqBuuZRpQE1Pomgf/OE/1Ez2U?=
 =?us-ascii?Q?jmrXoUqMOX6maDBoz99dIhNQG7dpMAsOCMVvXA77byCH7sjXNoU2F1wL21kw?=
 =?us-ascii?Q?SbZJlyouSr90JXv2rO8ly+uEwCTWClSaa/v/KQrNsls+jCMnKjIJlbDCLWJ0?=
 =?us-ascii?Q?DgcArKhPwh9o47Dx4VuLOTCa9kEOGbYuGsGhvPon3dNc0sVDc0lIEM850IBi?=
 =?us-ascii?Q?26KlClgNCDXenPXTLDMCibJFO3UYJlEWwgi71eMuatzpMgFXai/gPqJ7bPdV?=
 =?us-ascii?Q?9ARef4ePvjYtcz5EqlbVIXH8oQeybFNgCw+xcR19pA5isx29uLP6JOSaxTPH?=
 =?us-ascii?Q?8GILyszoFsXp7Bm03/GslJUeMb+v+CFHsGmy7hzfcHi4fvMcr1m/tnP1J7jv?=
 =?us-ascii?Q?5wB0LI6FtqCLPpYggLONzD9hPLV6ezqMdTFt6C000yxcBXY1Efc7+WiY5W7l?=
 =?us-ascii?Q?EIgommWBfq8IyhG43dXKygThuP6FhhXyUCgJG5yqJhJV6ivuERWUcoHEqYLR?=
 =?us-ascii?Q?uolrV2Gnr8F14LA6XnBNYtvX1xC1qZXagIocn8Po4OCuMXELgNpsjoJQZeYi?=
 =?us-ascii?Q?eqI9vR3vPH/2VBVRbXMMaihVqYRe0rXlLMAiYbrIHypTRUn9TXfctO3nYZ0T?=
 =?us-ascii?Q?DBfaseP6urbEbX6C45ekzeoQIq6gCRKONAiboV+ZfrlWTU0+iQ9mi5ou4ru0?=
 =?us-ascii?Q?PXT69917r4cE2gMv5Xwzqa3HaC/c151+BIBzdVwyaZ/ljksu7C4Sr2iFU9QA?=
 =?us-ascii?Q?OwehGUlfo6R2uqktapQiELf063WRHwaUe1JvIO+TQr02wV4Egjh8/FIiR3Ld?=
 =?us-ascii?Q?oFXlcz5gdC9PP3yDzHVSlib1IZ2jUN+3Et2VpXJ2c10VD4IZxFG7Dge2KA2X?=
 =?us-ascii?Q?61+qHPMDwVM8UdqXfZygNbPiz7k/p2RsKvB9J2pgIQOol1LcnrHIYVp9qSOD?=
 =?us-ascii?Q?NvM0Y/2U3g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0714761-c22e-44f0-5d73-08da1866412e
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 07:14:28.4385
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yHNAt1+XolI0OVht6YCTPZaa0I+HzxtoC2TrAgrKfhAzz2C8bVPZ0mFtj6+nM5A9TewsVVBEltePCjbecr2vIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3392
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Xiaomeng Tong
> Sent: Sunday, March 27, 2022 12:06 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>
> Cc: pabeni@redhat.com; intel-wired-lan@lists.osuosl.org; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org; Xiaomeng Tong
> <xiam0nd.tong@gmail.com>; jeffrey.t.kirsher@intel.com;
> netdev@vger.kernel.org; kuba@kernel.org; davem@davemloft.net
> Subject: [Intel-wired-lan] [PATCH] i40e: i40e_main: fix a missing check o=
n list
> iterator
>=20
> The bug is here:
> 	ret =3D i40e_add_macvlan_filter(hw, ch->seid, vdev->dev_addr,
> &aq_err);
>=20
> The list iterator 'ch' will point to a bogus position containing HEAD if =
the list is
> empty or no element is found. This case must be checked before any use of
> the iterator, otherwise it will lead to a invalid memory access.
>=20
> To fix this bug, use a new variable 'iter' as the list iterator, while us=
e the origin
> variable 'ch' as a dedicated pointer to point to the found element.
>=20
> Cc: stable@vger.kernel.org
> Fixes: 1d8d80b4e4ff6 ("i40e: Add macvlan support on i40e")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 27 +++++++++++----------
>  1 file changed, 14 insertions(+), 13 deletions(-)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)