Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993133AbXEBTKJ (ORCPT ); Wed, 2 May 2007 15:10:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2993136AbXEBTKI (ORCPT ); Wed, 2 May 2007 15:10:08 -0400 Received: from h155.mvista.com ([63.81.120.158]:25450 "EHLO gateway-1237.mvista.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S2993133AbXEBTJw (ORCPT ); Wed, 2 May 2007 15:09:52 -0400 Subject: Re: [PATCH 1/3] ia64: convert to use clocksource code From: Daniel Walker To: john stultz Cc: Peter Keilty , linux-ia64@vger.kernel.org, Eric Whitney , linux-kernel@vger.kernel.org In-Reply-To: <1178128707.6183.6.camel@localhost.localdomain> References: <20070426202632.23343.54944.sendpatchset@rambler.zko.hp.com> <1177621673.12796.121.camel@imap.mvista.com> <46320ACD.6090704@hp.com> <1177688158.12796.125.camel@imap.mvista.com> <463219CD.5040203@hp.com> <1177688931.12796.130.camel@imap.mvista.com> <463220C8.5060408@hp.com> <1178128707.6183.6.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 02 May 2007 12:08:01 -0700 Message-Id: <1178132881.12796.385.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 35 On Wed, 2007-05-02 at 10:58 -0700, john stultz wrote: > On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote: > > Daniel Walker wrote: > > >On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: > > >>>There is a read(), and a vread() did you modify the slow syscall path to > > >>>use the vread()? > > >>> > > >John mentioned that he thought fsys_mmio_ptr could be held in the vread > > >pointer. vread() is used in x86 for vsyscalls. It looks like you've used > > >the update_vsyscall() which is also used for vsyscalls. So vread could > > >also be used .. Have you considered that at all? > > > > > > > > No, but yes it can be done, overloading the meaning. > > Yea. I'm not really psyched about overloading the vread pointer's use. I > mentioned it could be done if the #ifdef was objected to, but it seems a > bit abusive. The #ifdef isn't great, but I think its something I can > live with for now. At least its explicit. Use of config options like that is a bad precedence I think, which is why I commented on it .. Since we have a vread pointer that exists already, and it's used a very similar purpose it seems like bloat to just add another pointer.. We could change the vread to be a plain void pointer, then let each architecture use it however they want. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/