Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp42652pxh; Thu, 7 Apr 2022 13:25:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3Gd504jf7Oe7G2Jg8fSIu54z4534L/ysmo85+IEjnryIm4SARCRSDeu1RXme2qOFabXiw X-Received: by 2002:a17:90b:4b10:b0:1c7:5b66:28df with SMTP id lx16-20020a17090b4b1000b001c75b6628dfmr17664056pjb.33.1649363119047; Thu, 07 Apr 2022 13:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649363119; cv=none; d=google.com; s=arc-20160816; b=nEHu7rodnjiFFLzE9WUKrEiNXjEIqZfHhKVJgsldiw/Zjsw9jBDl++0IYwJF/jqp9/ iHcOVxONWDjNO8JpuB2T28/sSXDN6p7uUOxUPJceV+rgQAwHPhE5VtdN0RxWH3oJfo8O l6CFfKg8VvXiIRc7wWPm2L64AlJEshsdW+DiTWDyzlQBbBefd07dtDe1gjgVvqIBQ12o TkxfGqsRrMdxon9DD3Mn0aP4vU2rW3id1BECZI4lRerZrpQAOJyJP/bCMu//6mbE0AJC ZXcVbHntQ3RIZE0k46mlSfGG2X68NVmwTZvJ6upBLw63XUDk/5HYa7pZWPHNBRms/9kl 47Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RWi0oBlMnwYXLG7IbRnVjvMgvvW6/2FhmtfIpq7Ox2A=; b=Gw09lRmVCK/FB/NtWBE6GimvkoibG8Qtalsob0FzgHCFRnxfu+KF/UIz0ue/80Pj1e yzMV048cT3spjfgy6vN5+sZUsSRAlyc0mxFDOS/KGmCatFS8+08XnW/k0H+VluNGz3Bz o5c6INshxbPB3CfiS5CiX9hZOUUSyzxNW2tA6GnOJzLYO3nV2O4MRvBXH1upilVO8LDN B2QpGEV63iAIcs/QB16dWUcN9VS5rIRxBwc5u94Fyuz3wAlPax06Gy0tTJBvH6+IMBX6 8e6hMGmLDwZv9tTTQuQSfyMq2a1K2UBX9DjJyzO5zUHLcWUZDeS7fEqjUTEawA6bXJvi +0eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="GKQ8b/kp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m123-20020a632681000000b003828bf085dbsi20043828pgm.850.2022.04.07.13.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 13:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="GKQ8b/kp"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F298D345D6C; Thu, 7 Apr 2022 12:39:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245628AbiDGNBh (ORCPT + 99 others); Thu, 7 Apr 2022 09:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245627AbiDGNBe (ORCPT ); Thu, 7 Apr 2022 09:01:34 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C29C1903D6 for ; Thu, 7 Apr 2022 05:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649336374; x=1680872374; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WovsgYiVLZg/i7UC+9r4MQsqX4gv9lKhRB/u0hmFKfI=; b=GKQ8b/kpuavsOokcR4+ahZPVRBAfinvttCTRpd4o/rmGqDaVHNqVjIoQ ho8O6Y3kNV3UZRdUCvkfG3M8pKiiTHoRBr2nllJCkDlINwwm+Cugerq6F 9Emo4llhBYriAhl/mCOCJ8BAr6aEy8DOfpcsvbPKegHVWa5mvO4ZFpzqU +opLtcM2SRKg9zESGLf2JYtaKwHGfPBgwRthEsMg+ph0qfwO4xEQAo2tc wxsWsObKtVK4kaZhhpY99xomd1U/SrHXoPX2KyGgJ0aHyiGhzQ/+1k905 eqyZNn2UxPoh7sVSjbuecU5eTjpOYwjg94++i4XIQ8hcNXpFLFlhL3Moa w==; X-IronPort-AV: E=McAfee;i="6400,9594,10309"; a="241907462" X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="241907462" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 05:59:34 -0700 X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="571040806" Received: from sannilnx.jer.intel.com ([10.12.231.73]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 05:59:30 -0700 From: Alexander Usyskin To: Greg Kroah-Hartman , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Tvrtko Ursulin Cc: Tomas Winkler , Alexander Usyskin , Vitaly Lubart , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/20] mei: gsc: add runtime pm handlers Date: Thu, 7 Apr 2022 15:58:23 +0300 Message-Id: <20220407125839.1479249-5-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220407125839.1479249-1-alexander.usyskin@intel.com> References: <20220407125839.1479249-1-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Reviewed-by: Rodrigo Vivi --- drivers/misc/mei/gsc-me.c | 67 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c index 58e39c00f150..32ea75f5e7aa 100644 --- a/drivers/misc/mei/gsc-me.c +++ b/drivers/misc/mei/gsc-me.c @@ -159,7 +159,72 @@ static int __maybe_unused mei_gsc_pm_resume(struct device *device) return 0; } -static SIMPLE_DEV_PM_OPS(mei_gsc_pm_ops, mei_gsc_pm_suspend, mei_gsc_pm_resume); +static int __maybe_unused mei_gsc_pm_runtime_idle(struct device *device) +{ + struct mei_device *dev = dev_get_drvdata(device); + + if (!dev) + return -ENODEV; + if (mei_write_is_idle(dev)) + pm_runtime_autosuspend(device); + + return -EBUSY; +} + +static int __maybe_unused mei_gsc_pm_runtime_suspend(struct device *device) +{ + struct mei_device *dev = dev_get_drvdata(device); + struct mei_me_hw *hw; + int ret; + + if (!dev) + return -ENODEV; + + mutex_lock(&dev->device_lock); + + if (mei_write_is_idle(dev)) { + hw = to_me_hw(dev); + hw->pg_state = MEI_PG_ON; + ret = 0; + } else { + ret = -EAGAIN; + } + + mutex_unlock(&dev->device_lock); + + return ret; +} + +static int __maybe_unused mei_gsc_pm_runtime_resume(struct device *device) +{ + struct mei_device *dev = dev_get_drvdata(device); + struct mei_me_hw *hw; + irqreturn_t irq_ret; + + if (!dev) + return -ENODEV; + + mutex_lock(&dev->device_lock); + + hw = to_me_hw(dev); + hw->pg_state = MEI_PG_OFF; + + mutex_unlock(&dev->device_lock); + + irq_ret = mei_me_irq_thread_handler(1, dev); + if (irq_ret != IRQ_HANDLED) + dev_err(dev->dev, "thread handler fail %d\n", irq_ret); + + return 0; +} + +static const struct dev_pm_ops mei_gsc_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(mei_gsc_pm_suspend, + mei_gsc_pm_resume) + SET_RUNTIME_PM_OPS(mei_gsc_pm_runtime_suspend, + mei_gsc_pm_runtime_resume, + mei_gsc_pm_runtime_idle) +}; static const struct auxiliary_device_id mei_gsc_id_table[] = { { -- 2.32.0