Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a3cb05a6-20c7-47af-3cca-ae225f56be85@redhat.com>
Date:   Thu, 7 Apr 2022 11:10:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [RESEND RFC PATCH 2/5] firmware: sysfb: Add helpers to unregister
 a pdev and disable registration
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Borislav Petkov <bp@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20220406213919.600294-1-javierm@redhat.com>
 <20220406213919.600294-3-javierm@redhat.com>
 <Yk6plGLa+uOb0ZyJ@phenom.ffwll.local>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <Yk6plGLa+uOb0ZyJ@phenom.ffwll.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/7/22 11:06, Daniel Vetter wrote:
> On Wed, Apr 06, 2022 at 11:39:16PM +0200, Javier Martinez Canillas wrote:

[snip]

>> +}
>> +EXPORT_SYMBOL_GPL(sysfb_try_unregister);
> 
> Kerneldoc for these plus adding that to
> Documentation/firmware/other_interfaces.rst would be really neat.
> 
> With that added Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
>

I will, thanks for pointing this out.
 -- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat