Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766679AbXEBTaa (ORCPT ); Wed, 2 May 2007 15:30:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1766637AbXEBTaa (ORCPT ); Wed, 2 May 2007 15:30:30 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35651 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1766679AbXEBTa1 (ORCPT ); Wed, 2 May 2007 15:30:27 -0400 Date: Wed, 2 May 2007 20:30:26 +0100 From: Christoph Hellwig To: Stefan Richter Cc: linux-kernel@vger.kernel.org, Kristian H??gsberg , Linus Torvalds , Andrew Morton , linux1394-devel , Christoph Hellwig Subject: Re: [PATCH 3/6] firewire: char device interface Message-ID: <20070502193026.GC1248@infradead.org> Mail-Followup-To: Christoph Hellwig , Stefan Richter , linux-kernel@vger.kernel.org, Kristian H??gsberg , Linus Torvalds , Andrew Morton , linux1394-devel References: <4637A29F.6070302@redhat.com> <20070502090007.GA28174@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 24 On Wed, May 02, 2007 at 02:17:26PM +0200, Stefan Richter wrote: > +#include > +#include Always use the +struct fw_cdev_get_info { > + /* The version field is just a running serial number. We > + * never break backwards compatibility. Userspace passes in > + * the version it expects and the kernel passes back the > + * highest version it can provide. Even if the structs in > + * this interface are extended in a later version, the kernel > + * will not copy back more data than what was present in the > + * interface version userspace expects. */ > + __u32 version; Please don't even try to build interfaces this complicated. If your current interface needs changes at some point just introduce new ioctls. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/