Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp48942pxh; Thu, 7 Apr 2022 13:36:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfgI2DDsGTK1tKnkGnX4ikH/1Rkw+gD01v4saPUNS/0dEgBNfjSK4CMkqfEd9ya+4sGi9K X-Received: by 2002:a05:6a00:1a90:b0:4fa:9400:afaf with SMTP id e16-20020a056a001a9000b004fa9400afafmr15696986pfv.82.1649363806816; Thu, 07 Apr 2022 13:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649363806; cv=none; d=google.com; s=arc-20160816; b=n1YZ3vAdRxcDQxfXuJa9QryEs5+jECfd0qujmLpzIbPrs77Dgr6NtOUdKl/y92tmLF PJyd1EBObB+IMNJXS4mqklcwiPPUjuBBQVPzr2KOBSLhoU7s/ih2CdqfEtrkSf0yOGuB 0mXgMo6i/REQT/DSZSLm3Awydc7MP14GhZg+KntA7Pk/YVYjDflmMSWcfe6RgoU8kfJl 6iMtRs1tx0fNLC+rDex6eTHrnd2s+QfQdgEbSsRMXp/34DluaeByvzSsBWVH8+bG1312 9omoEenlwNpFqhya8n32rBnjwOA9A/jkBA4MPxd047LjT10izRreCYGS6jcWEPZXMwkQ H51w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CWpyKykAaFKdj6tKW59wujBpq063E3mL7LJXeRpoRww=; b=gqWbEi2yWJGsigeWN2FnfSy6bxXaKqUaGDL7wt3pEQNV9DRBHk+wb38Mxt5hR62Dpt Bt9+6DaU+0MMozelyhj+xcHDSpT/YdkIiA07gisg0X109HoqXEBmbTW1GDglgP3trl31 ivB6MOM+0+hVMafKwKPQqg21gl7Xj0OBB0/k7q5yDxKZz1Il8p6IHKeXSBzIaak/tyRH ycjn1bPtqYVYZXTGnYWBGYD0WhZGFbzXJVwd6XDBYJqvIS82rOiBs1UgAjz+mDKhWvaV Gn1C5XUPjGcu9CNKm4bf7wHtlsdx3Uuusdio5hNRnC+XN9uxNrUigVQ/XDGML1mUMTaC LiIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id p14-20020a170902a40e00b00156a95ac6efsi549373plq.611.2022.04.07.13.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 13:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 86A5839F952; Thu, 7 Apr 2022 12:47:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238390AbiDGKRH (ORCPT + 99 others); Thu, 7 Apr 2022 06:17:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230034AbiDGKRE (ORCPT ); Thu, 7 Apr 2022 06:17:04 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B8BE4403D5; Thu, 7 Apr 2022 03:15:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 274A623A; Thu, 7 Apr 2022 03:15:04 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0248A3F5A1; Thu, 7 Apr 2022 03:15:02 -0700 (PDT) From: Sudeep Holla To: Liviu Dudau , Kees Cook Cc: Sudeep Holla , Lorenzo Pieralisi , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: vexpress/spc: Avoid negative array index when !SMP Date: Thu, 7 Apr 2022 11:14:52 +0100 Message-Id: <164932629049.1424947.13640596774017926989.b4-ty@arm.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220331190443.851661-1-keescook@chromium.org> References: <20220331190443.851661-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Mar 2022 12:04:43 -0700, Kees Cook wrote: > When building multi_v7_defconfig+CONFIG_SMP=n, -Warray-bounds exposes > a couple negative array index accesses: > > arch/arm/mach-vexpress/spc.c: In function 've_spc_clk_init': > arch/arm/mach-vexpress/spc.c:583:21: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds] > 583 | if (init_opp_table[cluster]) > | ~~~~~~~~~~~~~~^~~~~~~~~ > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table' > 556 | bool init_opp_table[MAX_CLUSTERS] = { false }; > | ^~~~~~~~~~~~~~ > arch/arm/mach-vexpress/spc.c:592:18: warning: array subscript -1 is below array bounds of 'bool[2]' {aka '_Bool[2]'} [-Warray-bounds] > 592 | init_opp_table[cluster] = true; > | ~~~~~~~~~~~~~~^~~~~~~~~ > arch/arm/mach-vexpress/spc.c:556:7: note: while referencing 'init_opp_table' > 556 | bool init_opp_table[MAX_CLUSTERS] = { false }; > | ^~~~~~~~~~~~~~ > > [...] Applied to sudeep.holla/linux (fixes/vexpress), thanks! [1/1] ARM: vexpress/spc: Avoid negative array index when !SMP https://git.kernel.org/sudeep.holla/c/b3f1dd52c9 -- Regards, Sudeep