Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 7 Apr 2022 10:59:17 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <mingo@redhat.com>, <mcgrof@kernel.org>, <xiaowei66@huawei.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ftrace: Fix build warning
Message-ID: <20220407105917.715eaa2e@gandalf.local.home>
In-Reply-To: <20220407074612.16608-1-yuehaibing@huawei.com>
References: <20220407074612.16608-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, 7 Apr 2022 15:46:12 +0800
YueHaibing <yuehaibing@huawei.com> wrote:

> If CONFIG_SYSCTL and CONFIG_DYNAMIC_FTRACE is n, build warns:
> 
> kernel/trace/ftrace.c:7912:13: error: ‘is_permanent_ops_registered’ defined but not used [-Werror=unused-function]
>  static bool is_permanent_ops_registered(void)
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> kernel/trace/ftrace.c:89:12: error: ‘last_ftrace_enabled’ defined but not used [-Werror=unused-variable]
>  static int last_ftrace_enabled;
>             ^~~~~~~~~~~~~~~~~~~
> 
> Move is_permanent_ops_registered() to ifdef block and mark last_ftrace_enabled as
> __maybe_unused to fix this.
> 
> Fixes: 7cde53da38a3 ("ftrace: move sysctl_ftrace_enabled to ftrace.c")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  kernel/trace/ftrace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve