Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp59799pxh; Thu, 7 Apr 2022 13:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqLWPKCHkQZ/64ljY9ELB5mKale8kXtDU29YX8SNe3iJtPgk4+7q1MSyjHWx6N3jBxeYmy X-Received: by 2002:a17:902:d714:b0:153:2e9:3bcc with SMTP id w20-20020a170902d71400b0015302e93bccmr15785689ply.83.1649365095692; Thu, 07 Apr 2022 13:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649365095; cv=none; d=google.com; s=arc-20160816; b=FBOapXempBK0lXRTzDs1CHcJ2ASiA9Qs0lYJ9LTbDP/ZzNcZNCwH/bqoZb9SBqjZmR F25wd5h2HB2pTVhsFJIgdv8zegeggbItbzSOLSvi0bztynNM0MsWEfpjAoGYZK4O4DYa TeXZkWskZGg2Ty60o2LnbgsLqKGpAZ9LuMzsYrjB2XywzmIrYsq9f28h67V/Xz+9k25I zgg/cQTmVtqKUuaL0NWH1gQnfc4ZGWyrp+ehyLPtJmdq+WCDHVuUsTIsfSHIvZNDFWzp 59YbNU7DCKPPFGNqVt3g+6Fco9Xey1iTZuTsoz3cfBpcywWLEg8v2b40GoQV7rGQSDX5 z8lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=2AloSS4NZB2+ZrfeSSgqxJ8kUJYni0g4gfNrs9qyExI=; b=KQSWfNRBv3Tss9I/abcylbB8UKlBpnP140Vx/g/Bi4AAl7FBlR1saaF0sU40/pkToS CmFi+V8y94SZ9it5LrmXI4cP2iBnMnyGqF+9b8jahu0RxMsuMeF+dDsp7N/L+8qf8WC7 wrHG3Xy005GOryk/WLbykKHYNlt9XS6SIx6YwGS4pP9pdKw2VVaU+XI1WkFLCWpYprTA tyohuXqS4U6HbXoLGmgUabdGMwRogP75fM3OMje3frOu6kOwgkr1g5iJWzJAytx9K3VC Bhkcog+BRQu1h4It3zWv9tc1NFh5FF7Boiz5GuKjzW7qUJTstPPWs1CaErjwPluvcqRk L3ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YycBXWVY; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q2-20020a056a00084200b004faa67abb7fsi19111085pfk.46.2022.04.07.13.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 13:58:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YycBXWVY; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 567B0415567; Thu, 7 Apr 2022 13:01:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346012AbiDGRPo (ORCPT + 99 others); Thu, 7 Apr 2022 13:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345995AbiDGRPg (ORCPT ); Thu, 7 Apr 2022 13:15:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C7CD194FD0; Thu, 7 Apr 2022 10:13:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 43AF5B8254E; Thu, 7 Apr 2022 17:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFD50C385A4; Thu, 7 Apr 2022 17:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649351577; bh=xoNNkCB4KczoI5BLU4qiA3mDQpdHlNlRPZpZI5L4AsI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=YycBXWVYYJmqhOL6ZSUZNReU6W2XswiR8+yjRYGc3HC08TwOBg4uyWBRr5TNZyoLQ N6Swe3Mq9vyKHJuhbaIQwcOAgSEPKqCtJgo3fI56GHC+VSpiVBiOv2g0BDCDMroseu X8/oBvRxOUj8qavbJVzCQDMRicT/gVwI47YbmUVAM8pCVm6MjzPuyIARvZKDqlK0U/ MFtxfypz4YVhjA36o8YkJFtL5qM9bOxdoChG+HrqdPBRr9SXuNIqzVnDi7nlIYyWiZ 96Q8KvDjtsumPsKbLxwviSXJHmjam7BU7EkuPw2ZY3kOV7ufUJUgtQeVvgzX46OMwA OuI2haGRk6eXA== From: Mark Brown To: matthias.schiffer@ew.tq-group.com Cc: tudor.ambarus@microchip.com, linux-spi@vger.kernel.org, vadivel.muruganx.ramuthevar@linux.intel.com, vigneshr@ti.com, linux-kernel@vger.kernel.org In-Reply-To: <20220331110819.133392-1-matthias.schiffer@ew.tq-group.com> References: <20220331110819.133392-1-matthias.schiffer@ew.tq-group.com> Subject: Re: [PATCH] spi: cadence-quadspi: fix protocol setup for non-1-1-X operations Message-Id: <164935157541.1057547.6578731972016383100.b4-ty@kernel.org> Date: Thu, 07 Apr 2022 18:12:55 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Mar 2022 13:08:19 +0200, Matthias Schiffer wrote: > cqspi_set_protocol() only set the data width, but ignored the command > and address width (except for 8-8-8 DTR ops), leading to corruption of > all transfers using 1-X-X or X-X-X ops. Fix by setting the other two > widths as well. > > While we're at it, simplify the code a bit by replacing the > CQSPI_INST_TYPE_* constants with ilog2(). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: cadence-quadspi: fix protocol setup for non-1-1-X operations commit: 97e4827d775faa9a32b5e1a97959c69dd77d17a3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark