Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 7 Apr 2022 17:37:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Akihiko Odaki <akihiko.odaki@gmail.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Jaroslav Kysela <perex@perex.cz>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rt5682: Add jack kcontrol
Message-ID: <Yk8TLUnEHRKstyxq@sirena.org.uk>
References: <20220407141316.5099-1-akihiko.odaki@gmail.com>
 <Yk7+jbQ0KBM0zVh9@sirena.org.uk>
 <96dae189-c0ff-4054-3d00-41c3b44c2cd6@gmail.com>
 <Yk8Ktyyt0veW4g+j@sirena.org.uk>
 <f86a10e1-b5a7-5c59-8e53-cec65d97234b@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="K9Hi8t9P2T4/0vtf"
Content-Disposition: inline
In-Reply-To: <f86a10e1-b5a7-5c59-8e53-cec65d97234b@gmail.com>
Precedence: bulk


--K9Hi8t9P2T4/0vtf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

j
On Fri, Apr 08, 2022 at 01:11:22AM +0900, Akihiko Odaki wrote:
> On 2022/04/08 1:00, Mark Brown wrote:

> > That bit is very common but there's still machine specific aspects - is
> > the required hardware wired up, if it is wired up how exactly are things
> > wired (separate microphone jack, headset jack, one of many jacks?).  A
> > lot of the machine driver part of things is about labeling things so
> > that it can be displayed in a way that's easy to connect to the physical
> > system.  Generally the machine driver would define a jack and then
> > connect the CODEC to it.

> Whether the required hardware wired is told from the user of the codec via
> jack's type specified with snd_soc_card_jack_new(). The other details live
> in the codec.

So I'm confused about what problem this patch is intended to fix.  It
really sounds like there's some issue with the driver not using standard
interfaces that you're trying to work around but the changelog is not at
all clear.  The "doesn't use DAPM" bit is a bit of a warning sign, it
sounds like the audio signals to and from the CODEC aren't being
connected to the jack properly.

Look at how other devices with jack detection hardware handle this and
follow a similar pattern.

--K9Hi8t9P2T4/0vtf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJPEywACgkQJNaLcl1U
h9BD0wf/VfBhw9GQTwXU5Qj1Mq/d+fRP1+2jj+kUbV7xuu9nyDuVH7YLFP/Da2G5
dFgQBgY6vSA7++fPrbG4kqzGpvLPcNy6s+kjZHj2anBccZg/4Q9yADqp5ifggHcj
o/ltdaGMidJydvYgAF0EZnoW37eKRXNR/caF2nvE4aa7X9t/e3FOFQsfEP9nYi6Y
8zyr5aUabYQe5NYx903wgSoUKQoc0c8VS820KAxyoSw5T7Y3O/CprXZyFk8Wc05y
OpPLRzW2d/fqjWe/bhzaC2AYICirJSaO7R6fAMaV12fbZJj4i+F5K3+CU/7GlWc0
H3WCDElgw0O9PivSGGwzUasIlzOWYw==
=9nxM
-----END PGP SIGNATURE-----

--K9Hi8t9P2T4/0vtf--